Fix: handle proxy internal callbacks in callback management test #12294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test_list_callbacks_mixed_callback_types test was failing when run in parallel with other tests due to the proxy server's internal _PROXY_VirtualKeyModelMaxBudgetLimiter callback persisting across test runs. This fix filters out proxy internal callbacks from the test assertions to ensure consistent test behavior regardless of test execution order or parallelization.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
cc @jugaldb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix: handle proxy internal callbacks in callback management test
Relevant issues
Fixes test failure in
test_list_callbacks_mixed_callback_typeswhen running tests in parallelPre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
Changes
test_list_callbacks_mixed_callback_typesto filter out proxy-internal callbacks that can persist when tests run in parallel_PROXY_VirtualKeyModelMaxBudgetLimitercallback that gets added by the proxy server initializationThe test was failing with:
This happened because when tests run in parallel, the proxy server's internal callbacks can persist across test runs. The fix filters out these internal callbacks from the test assertions.
Test Results
All tests now pass:
$ poetry run pytest tests/test_litellm/proxy/management_endpoints/test_callback_management_endpoints.py -xvs -n 4 ... ======================== 5 passed, 17 warnings in 5.33s ========================