Retain schema field ordering for google gemini and vertex #9828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adrianlyjak
force-pushed
the
9783
branch
2 times, most recently
from
5f6c455 to
20a8f01
Compare
|
Hi @adrianlyjak can you resolve the conflict - this looks good to merge |
@krrishdholakia resolved |
krrishdholakia
pushed a commit
that referenced
this pull request
Apr 16, 2025
krrishdholakia
added a commit
that referenced
this pull request
Apr 16, 2025
…ltiple tool calls (#10040) * fix #9783: Retain schema field ordering for google gemini and vertex (#9828) * test: update test * refactor(groq.py): initial commit migrating groq to base_llm_http_handler * fix(streaming_chunk_builder_utils.py): fix how tool content is combined Fixes #10034 * fix(vertex_ai/common_utils.py): prevent infinite loop in helper function * fix(groq/chat/transformation.py): handle groq streaming errors correctly * fix(groq/chat/transformation.py): handle max_retries --------- Co-authored-by: Adrian Lyjak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Retain schema field ordering for google gemini and vertex by specifying
propertyOrderingRelevant issues
fixes #9783
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]Type
🐛 Bug Fix
Changes
This change adds the
propertyOrderingfield to vertex/gemini schemas, in order to retain pydantic and dictionary ordering of fields, otherwise the google APIs will alphabetize the fields.I'd previously discovered this strange behavior in ~December 2024. At that time, the ai studio version of the API didin't support the
propertyOrderingfield, only vertex. Since then, they seem to have added it: https://ai.google.dev/gemini-api/docs/structured-output?lang=python. I verified with some basic scripts against the actual vertex and ai studio gemini APIs that this works without error.