Refactor sqlthread and test

Author: shekhar-cis

src/class_sqlThread.py

@@ -81,6 +81,9 @@ def initialize_sql(self, file_name):
         except IOError as err:
             logger.debug(
                 'ERROR trying to initialize database. Error message: %s\n', str(err))
+        except OSError as err:
+            logger.debug('The file is missing. Error message: %s\n', str(err))
+            return
         except Exception as err:
             logger.debug(
                 'ERROR trying to initialize database. Error message: %s\n', str(err))
@@ -109,7 +112,7 @@ def upgrade_to_latest(self):
 
         while self.sql_schema_version < self.max_level:
             self._upgrade_one_level_sql_statement(self.sql_schema_version)
-            self.sql_schema_version = True
+            self.sql_schema_version = True  # bump sql_schema_version by one
 
     def upgrade_schema_if_old_version(self):
         """ check settings table exists """
@@ -291,9 +294,7 @@ def upgrade_config_setting_version(self):
     def error_handler(err, custom_error):
         if str(err) == 'database or disk is full':
             logger.fatal(
-                "(While {}) Alert: Your disk or data storage volume is full. sqlThread will now exit.".format(
-                    custom_error
-                )
+                "(While %s) Alert: Your disk or data storage volume is full. sqlThread will now exit.", custom_error
             )
             queues.UISignalQueue.put((
                 'alert', (

src/tests/test_sqlthread.py

@@ -213,12 +213,10 @@ def test_bm_db_version_10(self):
         res = self.test_db.cur.fetchall()
         self.assertEqual(res[0][0], label, "Data not migrated for version 10")
 
-    @version
     def test_bm_db_version_type(self):
         """
             Test version type
         """
         self.test_db.cur.execute('''INSERT INTO settings VALUES('version','test_string')''')  # noqa
-        version = self.test_db.cur.execute("SELECT * FROM settings WHERE key='version'")
-        res = version.fetchall()
-        self.assertEqual(type(res[0][1]), int)
+        res = self.test_db.sql_schema_version
+        self.assertEqual(type(res), int)