Button icons are now showing for table row buttons#18474
Open
mohagan9 wants to merge 1 commit intoBudibase:masterfrom
Open
Button icons are now showing for table row buttons#18474mohagan9 wants to merge 1 commit intoBudibase:masterfrom
mohagan9 wants to merge 1 commit intoBudibase:masterfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Show button icons for table rows and collapsible buttons
Screenshots
Launchcontrol
Show icons in row buttons
Summary by cubic
Icons now show on table row buttons and in the collapsed button menu, fixing missing icons and keeping the UI consistent.
icontoButtoninpackages/frontend-core/src/components/grid/layout/ButtonColumn.svelteand toMenuIteminpackages/bbui/src/ButtonGroup/CollapsedButtonGroup.svelte.<i>markup and rely on componenticonprops for consistent rendering.Written for commit b09d7ca. Summary will update on new commits.