This repository was archived by the owner on Mar 5, 2025. It is now read-only.
ci: run bitcoin core regtest node for tests #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xJonathanLEI
force-pushed
the
ci/fix_failed_tests
branch
from
d21f33f to
51df3d6
Compare
xJonathanLEI
changed the title
xJonathanLEI
changed the title
Contributor
Author
|
Btw I tried fixing the Need to restructure the tests a bit more to fully resolve. |
mimoo
reviewed
Jan 27, 2024
| args: run --all-features --release | ||
| # Test `get_zkapps` is skipped on CI for now as it uses a hard-coded testnet address | ||
| # TODO: remove this exclusion once the test becomes end-to-end | ||
| args: run --all-features --release -E "package(zkbitcoin) - test(get_zkapps)" |
Contributor
There was a problem hiding this comment.
you can add #[ignore] under the #[test] of the test also
mimoo
reviewed
Jan 27, 2024
mimoo
approved these changes
Jan 27, 2024
Contributor
mimoo
left a comment
mimoo
left a comment
There was a problem hiding this comment.
this is AMAZING! thank-you so much :) maybe we should add some doc in DEVELOPER.md on how to run the tests locally with regtest as well!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Red CI leaves newcomers a really bad impression :(
What this PR does:
.instead of:.get_zkappstest on CI as it hard-codes a testnet address. (IMO ideally this test would become end-to-end so this would no longer be an issue)Even with changes proposed here, CI is still red, but that's because of clippy. The testing step is actually successful. Clippy issues should be addresses in a separate PR.