Use sentence case for Network context menu items

Screenshot: http://b/451526111#attachment71804367
Bug: 451526111
Change-Id: I37ec37011b3d130a249c49ac1ae3cd2af534fac1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7260955
Auto-Submit: Kateryna Prokopenko <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Reviewed-by: Samiya Caur <[email protected]>
Commit-Queue: Kateryna Prokopenko <[email protected]>

Author: Kateryna Prokopenko

front_end/panels/network/NetworkLogView.test.ts

@@ -1066,20 +1066,20 @@ Invoke-WebRequest -UseBasicParsing -Uri "url-header-und-content-overridden"`]);
     const contextMenu = contextMenuShow.thisValues[0];
 
     const requestHeadersSubMenu = contextMenu.footerSection().items.find(
-        (item: UI.ContextMenu.Item) => item.buildDescriptor().label === 'Request Headers');
-    assert.exists(requestHeadersSubMenu, '"Request Headers" submenu should exist');
+        (item: UI.ContextMenu.Item) => item.buildDescriptor().label === 'Request headers');
+    assert.exists(requestHeadersSubMenu, '"Request headers" submenu should exist');
     assert.instanceOf(requestHeadersSubMenu, UI.ContextMenu.SubMenu);
     const customRequestHeaderItem = requestHeadersSubMenu.defaultSection().items.find(
         (item: UI.ContextMenu.Item) => item.buildDescriptor().label === customRequestTitle);
-    assert.exists(customRequestHeaderItem, 'Custom request header item should be in the "Request Headers" submenu');
+    assert.exists(customRequestHeaderItem, 'Custom request header item should be in the "Request headers" submenu');
 
     const responseHeadersSubMenu = contextMenu.footerSection().items.find(
-        (item: UI.ContextMenu.Item) => item.buildDescriptor().label === 'Response Headers');
-    assert.exists(responseHeadersSubMenu, '"Response Headers" submenu should exist');
+        (item: UI.ContextMenu.Item) => item.buildDescriptor().label === 'Response headers');
+    assert.exists(responseHeadersSubMenu, '"Response headers" submenu should exist');
     assert.instanceOf(responseHeadersSubMenu, UI.ContextMenu.SubMenu);
     const customResponseHeaderItem = responseHeadersSubMenu.defaultSection().items.find(
         (item: UI.ContextMenu.Item) => item.buildDescriptor().label === customResponseTitle);
-    assert.exists(customResponseHeaderItem, 'Custom response header item should be in the "Response Headers" submenu');
+    assert.exists(customResponseHeaderItem, 'Custom response header item should be in the "Response headers" submenu');
   });
 
   describe('Request blocking and throttling', () => {

front_end/panels/network/NetworkLogViewColumns.ts

@@ -31,31 +31,31 @@ const UIStrings = {
   /**
    * @description A context menu item in the Network Log View Columns of the Network panel
    */
-  responseHeaders: 'Response Headers',
+  responseHeaders: 'Response headers',
   /**
    * @description A context menu item in the Network Log View Columns of the Network panel
    */
-  requestHeaders: 'Request Headers',
+  requestHeaders: 'Request headers',
   /**
    * @description Text in Network Log View Columns of the Network panel
    */
   manageHeaderColumns: 'Manage Header Columns…',
   /**
    * @description Text for the start time of an activity
    */
-  startTime: 'Start Time',
+  startTime: 'Start time',
   /**
    * @description Text in Network Log View Columns of the Network panel
    */
-  responseTime: 'Response Time',
+  responseTime: 'Response time',
   /**
    * @description Text in Network Log View Columns of the Network panel
    */
-  endTime: 'End Time',
+  endTime: 'End time',
   /**
    * @description Text in Network Log View Columns of the Network panel
    */
-  totalDuration: 'Total Duration',
+  totalDuration: 'Total duration',
   /**
    * @description Text for the latency of a task
    */
@@ -99,7 +99,7 @@ const UIStrings = {
   /**
    * @description Text in Network Log View Columns of the Network panel
    */
-  remoteAddress: 'Remote Address',
+  remoteAddress: 'Remote address',
   /**
    * @description Text that refers to some types
    */
@@ -115,7 +115,7 @@ const UIStrings = {
   /**
    * @description Column header in the Network log view of the Network panel
    */
-  initiatorAddressSpace: 'Initiator Address Space',
+  initiatorAddressSpace: 'Initiator address space',
   /**
    * @description Text for web cookies
    */
@@ -147,7 +147,7 @@ const UIStrings = {
   /**
    * @description Text in Network Log View Columns of the Network panel
    */
-  remoteAddressSpace: 'Remote Address Space',
+  remoteAddressSpace: 'Remote address space',
   /**
    * @description Text to show whether a request is ad-related
    */

front_end/panels/network/components/RequestHeadersView.test.ts

@@ -168,7 +168,7 @@ describeWithMockConnection('RequestHeadersView', () => {
     component = await renderHeadersComponent(defaultRequest);
     assert.isNotNull(component.shadowRoot);
 
-    const responseHeadersCategory = component.shadowRoot.querySelector('[aria-label="Response Headers"]');
+    const responseHeadersCategory = component.shadowRoot.querySelector('[aria-label="Response headers"]');
     assert.instanceOf(responseHeadersCategory, HTMLElement);
     assert.deepEqual(
         getRowsTextFromCategory(responseHeadersCategory),
@@ -185,7 +185,7 @@ describeWithMockConnection('RequestHeadersView', () => {
     component = await renderHeadersComponent(defaultRequest);
     assert.isNotNull(component.shadowRoot);
 
-    const earlyHintsCategory = component.shadowRoot.querySelector('[aria-label="Early Hints Headers"]');
+    const earlyHintsCategory = component.shadowRoot.querySelector('[aria-label="Early hints headers"]');
     assert.instanceOf(earlyHintsCategory, HTMLElement);
     assert.deepEqual(getRowsTextFromCategory(earlyHintsCategory), [['link', '<src="/script.js" as="script">']]);
   });
@@ -210,7 +210,7 @@ describeWithMockConnection('RequestHeadersView', () => {
     component = await renderHeadersComponent(defaultRequest);
     assert.isNotNull(component.shadowRoot);
 
-    const responseHeadersCategory = component.shadowRoot.querySelector('[aria-label="Response Headers"]');
+    const responseHeadersCategory = component.shadowRoot.querySelector('[aria-label="Response headers"]');
     assert.instanceOf(responseHeadersCategory, HTMLElement);
 
     // Switch to viewing source view
@@ -246,7 +246,7 @@ describeWithMockConnection('RequestHeadersView', () => {
     } as unknown as SDK.NetworkRequest.NetworkRequest);
     assert.isNotNull(component.shadowRoot);
 
-    const responseHeadersCategory = component.shadowRoot.querySelector('[aria-label="Response Headers"]');
+    const responseHeadersCategory = component.shadowRoot.querySelector('[aria-label="Response headers"]');
     assert.instanceOf(responseHeadersCategory, HTMLElement);
 
     // Switch to viewing source view
@@ -279,7 +279,7 @@ describeWithMockConnection('RequestHeadersView', () => {
 
     component = await renderHeadersComponent(request);
     assert.isNotNull(component.shadowRoot);
-    const responseHeadersCategory = component.shadowRoot.querySelector('[aria-label="Response Headers"]');
+    const responseHeadersCategory = component.shadowRoot.querySelector('[aria-label="Response headers"]');
     assert.instanceOf(responseHeadersCategory, HTMLElement);
 
     const spy = sinon.spy(component, 'render');
@@ -305,7 +305,7 @@ describeWithMockConnection('RequestHeadersView', () => {
     component = await renderHeadersComponent(request);
     assert.isNotNull(component.shadowRoot);
 
-    const responseHeadersCategory = component.shadowRoot.querySelector('[aria-label="Response Headers"]');
+    const responseHeadersCategory = component.shadowRoot.querySelector('[aria-label="Response headers"]');
     assert.instanceOf(responseHeadersCategory, HTMLElement);
     assert.deepEqual(
         getRowsTextFromCategory(responseHeadersCategory),
@@ -354,7 +354,7 @@ describeWithMockConnection('RequestHeadersView', () => {
     component = await renderHeadersComponent(defaultRequest);
     assert.isNotNull(component.shadowRoot);
 
-    const responseHeadersCategory = component.shadowRoot.querySelector('[aria-label="Response Headers"]');
+    const responseHeadersCategory = component.shadowRoot.querySelector('[aria-label="Response headers"]');
     assert.instanceOf(responseHeadersCategory, HTMLElement);
     assert.isNotNull(responseHeadersCategory.shadowRoot);
 
@@ -380,7 +380,7 @@ describeWithMockConnection('RequestHeadersView', () => {
     component = await renderHeadersComponent(defaultRequest);
     assert.isNotNull(component.shadowRoot);
 
-    const responseHeadersCategory = component.shadowRoot.querySelector('[aria-label="Response Headers"]');
+    const responseHeadersCategory = component.shadowRoot.querySelector('[aria-label="Response headers"]');
     assert.instanceOf(responseHeadersCategory, HTMLElement);
     assert.isNotNull(responseHeadersCategory.shadowRoot);
 

front_end/panels/network/components/RequestHeadersView.ts

@@ -86,11 +86,11 @@ const UIStrings = {
   /**
    * @description A context menu item in the Network Log View Columns of the Network panel
    */
-  responseHeaders: 'Response Headers',
+  responseHeaders: 'Response headers',
   /**
    * @description A context menu item in the Network Log View Columns of the Network panel
    */
-  earlyHintsHeaders: 'Early Hints Headers',
+  earlyHintsHeaders: 'Early hints headers',
   /**
    * @description Title text for a link to the Sources panel to the file containing the header override definitions
    */

front_end/ui/legacy/components/data_grid/DataGrid.ts

@@ -68,15 +68,15 @@ const UIStrings = {
   /**
    * @description A context menu item in the Data Grid of a data grid
    */
-  sortByString: 'Sort By',
+  sortByString: 'Sort by',
   /**
    * @description A context menu item in data grids to reset the columns to their default weight
    */
-  resetColumns: 'Reset Columns',
+  resetColumns: 'Reset columns',
   /**
    * @description A context menu item in data grids to list header options.
    */
-  headerOptions: 'Header Options',
+  headerOptions: 'Header options',
   /**
    * @description Text to refresh the page
    */

test/e2e/network/network-datagrid.test.ts

@@ -77,7 +77,7 @@ describe('The Network Tab', function() {
 
     await devToolsPage.click('.name-column', {clickOptions: {button: 'right'}});
 
-    await devToolsPage.click('aria/Response Headers');
+    await devToolsPage.click('aria/Response headers');
 
     await devToolsPage.click('aria/Last-Modified, unchecked');
 
@@ -217,9 +217,9 @@ describe('The Network Tab', function() {
 
     await devToolsPage.click('.name-column', {clickOptions: {button: 'right'}});
 
-    await devToolsPage.click('aria/Initiator Address Space, unchecked');
+    await devToolsPage.click('aria/Initiator address space, unchecked');
 
-    const expectedValues = JSON.stringify(['Initiator Address Space', '', 'Loopback']);
+    const expectedValues = JSON.stringify(['Initiator address space', '', 'Loopback']);
     await devToolsPage.waitForFunction(async () => {
       const initiatorAddressSpaceValues = await devToolsPage.page.$$eval(
           'pierce/.initiator-address-space-column',
@@ -241,9 +241,9 @@ describe('The Network Tab', function() {
 
     await devToolsPage.click('.name-column', {clickOptions: {button: 'right'}});
 
-    await devToolsPage.click('aria/Remote Address Space, unchecked');
+    await devToolsPage.click('aria/Remote address space, unchecked');
 
-    const expectedValues = JSON.stringify(['Remote Address Space', 'Loopback', 'Loopback']);
+    const expectedValues = JSON.stringify(['Remote address space', 'Loopback', 'Loopback']);
     await devToolsPage.waitForFunction(async () => {
       const remoteAddressSpaceValues = await devToolsPage.page.$$eval(
           'pierce/.remote-address-space-column',

test/e2e/network/network-request-view.test.ts

@@ -31,7 +31,7 @@ const configureAndCheckHeaderOverrides = async (devToolsPage: DevToolsPage, insp
     root: networkView,
   });
   await devToolsPage.waitFor('#tab-headers-component[role=tab][aria-selected=true]', networkView);
-  let responseHeaderSection = await devToolsPage.waitFor('[aria-label="Response Headers"]', networkView);
+  let responseHeaderSection = await devToolsPage.waitFor('[aria-label="Response headers"]', networkView);
 
   let row = await devToolsPage.waitFor('.row', responseHeaderSection);
   assert.deepEqual(await getTextFromHeadersRow(row, devToolsPage), [
@@ -62,7 +62,7 @@ const configureAndCheckHeaderOverrides = async (devToolsPage: DevToolsPage, insp
     root: networkView,
   });
 
-  responseHeaderSection = await devToolsPage.waitFor('[aria-label="Response Headers"]');
+  responseHeaderSection = await devToolsPage.waitFor('[aria-label="Response headers"]');
   row = await devToolsPage.waitFor('.row.header-overridden', responseHeaderSection);
   assert.deepEqual(await getTextFromHeadersRow(row, devToolsPage), ['cache-control', 'Foo']);
 };
@@ -368,7 +368,7 @@ describe('The Network Request view', () => {
         ],
       },
       {
-        aria: 'Response Headers',
+        aria: 'Response headers',
         rows: [
           'cache-control',
           'max-age=%',
@@ -479,7 +479,7 @@ describe('The Network Request view', () => {
       root: networkView,
     });
     await devToolsPage.waitFor('[aria-label=Headers][role=tab][aria-selected=true]', networkView);
-    const section = await devToolsPage.waitFor('[aria-label="Response Headers"]');
+    const section = await devToolsPage.waitFor('[aria-label="Response headers"]');
     await devToolsPage.click('input', {
       root: section,
     });

test/e2e/sources/header-overrides.test.ts

@@ -25,7 +25,7 @@ const FILE_TREE_HEADERS_FILE_SELECTOR = '[aria-label=".headers, file"] .tree-ele
 const NETWORK_VIEW_SELECTOR = '.network-item-view';
 const HEADERS_TAB_SELECTOR = '[aria-label=Headers][role="tab"]';
 const ACTIVE_HEADERS_TAB_SELECTOR = '[aria-label=Headers][role=tab][aria-selected=true]';
-const RESPONSE_HEADERS_SELECTOR = '[aria-label="Response Headers"]';
+const RESPONSE_HEADERS_SELECTOR = '[aria-label="Response headers"]';
 const HEADER_ROW_SELECTOR = '.row';
 
 async function createHeaderOverride(devToolsPage: DevToolsPage) {