Skip to content

feat: Qdrant vectorstore support #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 15, 2024
Merged

feat: Qdrant vectorstore support #260

merged 5 commits into from
Sep 15, 2024

Conversation

Anush008
Copy link
Contributor

@Anush008 Anush008 commented Sep 9, 2024

Description

Type of change

  • New features (non-breaking change).

@Anush008
Copy link
Contributor Author

The failed test seems unrelated to the PR.

@Anush008
Copy link
Contributor Author

Hey @taprosoft. Just bumping this PR.
Please take a look when possible.

@taprosoft
Copy link
Contributor

Thanks @Anush008 for your contribution. Basically the implementation looks good and clean. Please fix the unit-tests and address my comment above. Then, the PR is ready to merge.

@Anush008
Copy link
Contributor Author

🟢

Copy link
Contributor

@taprosoft taprosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taprosoft taprosoft merged commit e2bd78e into Cinnamon:main Sep 15, 2024
5 checks passed
@Anush008 Anush008 deleted the qdrant branch November 6, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants