Make custom debug log function on-par with the built-in one #1317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@jkaflik PTAL 🙏 |
vespian
force-pushed
the
prozlach/debug_log_info
branch
3 times, most recently
from
fa1443d to
62a07d4
Compare
vespian
force-pushed
the
prozlach/debug_log_info
branch
from
62a07d4 to
2f38404
Compare
|
@jkaflik Fixed - both CLA and tests failures. PTAL. |
|
@jkaflik I have run tests locally and they passed. I am unfamiliar with your testing setup and whether the failures here are legit. Is there anything I could help here with? |
|
No worries. We have CI runners instability - I will take care of it. |
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Jul 10, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://togithub.com/ClickHouse/clickhouse-go) | `v2.23.0` -> `v2.26.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.26.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2260-2024-06-25----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.25.0...v2.26.0) #### What's Changed ##### Enhancements 🎉 - Reintroduce the random connection strategy by [@​larry-cdn77](https://togithub.com/larry-cdn77) in [https://github.com/ClickHouse/clickhouse-go/pull/1313](https://togithub.com/ClickHouse/clickhouse-go/pull/1313) - Make custom debug log function on-par with the built-in one by [@​vespian](https://togithub.com/vespian) in [https://github.com/ClickHouse/clickhouse-go/pull/1317](https://togithub.com/ClickHouse/clickhouse-go/pull/1317) - Remove date overflow check as it's normalised by ClickHouse server by [@​gogingersnap777](https://togithub.com/gogingersnap777) in [https://github.com/ClickHouse/clickhouse-go/pull/1315](https://togithub.com/ClickHouse/clickhouse-go/pull/1315) - Batch: impl `Columns() []column.Interface` method by [@​egsam98](https://togithub.com/egsam98) in [https://github.com/ClickHouse/clickhouse-go/pull/1277](https://togithub.com/ClickHouse/clickhouse-go/pull/1277) ##### Fixes 🐛 - Fix rows.Close do not return too early by [@​yujiarista](https://togithub.com/yujiarista) in [https://github.com/ClickHouse/clickhouse-go/pull/1314](https://togithub.com/ClickHouse/clickhouse-go/pull/1314) - Setting `X-Clickhouse-SSL-Certificate-Auth` header correctly given `X-ClickHouse-Key` by [@​gogingersnap777](https://togithub.com/gogingersnap777) in [https://github.com/ClickHouse/clickhouse-go/pull/1316](https://togithub.com/ClickHouse/clickhouse-go/pull/1316) - Retry on network errors and fix retries on async inserts with `database/sql` interface by [@​tommyzli](https://togithub.com/tommyzli) in [https://github.com/ClickHouse/clickhouse-go/pull/1330](https://togithub.com/ClickHouse/clickhouse-go/pull/1330) - BatchInsert parentheses issue fix by [@​ramzes642](https://togithub.com/ramzes642) in [https://github.com/ClickHouse/clickhouse-go/pull/1327](https://togithub.com/ClickHouse/clickhouse-go/pull/1327) ##### Other Changes 🛠 - ClickHouse 24.5 by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1319](https://togithub.com/ClickHouse/clickhouse-go/pull/1319) - Align `allow_suspicious_low_cardinality_types` and ` allow_suspicious_low_cardinality_types ` settings in tests due to ClickHouse Cloud incompatibility by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1331](https://togithub.com/ClickHouse/clickhouse-go/pull/1331) - Use HTTPs scheme in std connection failover tests by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1332](https://togithub.com/ClickHouse/clickhouse-go/pull/1332) #### New Contributors - [@​larry-cdn77](https://togithub.com/larry-cdn77) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1313](https://togithub.com/ClickHouse/clickhouse-go/pull/1313) - [@​vespian](https://togithub.com/vespian) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1317](https://togithub.com/ClickHouse/clickhouse-go/pull/1317) - [@​gogingersnap777](https://togithub.com/gogingersnap777) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1315](https://togithub.com/ClickHouse/clickhouse-go/pull/1315) - [@​yujiarista](https://togithub.com/yujiarista) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1314](https://togithub.com/ClickHouse/clickhouse-go/pull/1314) - [@​egsam98](https://togithub.com/egsam98) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1277](https://togithub.com/ClickHouse/clickhouse-go/pull/1277) - [@​tommyzli](https://togithub.com/tommyzli) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1330](https://togithub.com/ClickHouse/clickhouse-go/pull/1330) - [@​ramzes642](https://togithub.com/ramzes642) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1327](https://togithub.com/ClickHouse/clickhouse-go/pull/1327) **Full Changelog**: ClickHouse/clickhouse-go@v2.25.0...v2.26.0 ### [`v2.25.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2250-2024-05-28----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.24.0...v2.25.0) #### What's Changed ##### Fixes 🐛 - Add a compatibility layer for a database/sql driver to work with sql.NullString and ClickHouse nullable column by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1306](https://togithub.com/ClickHouse/clickhouse-go/pull/1306) ##### Other Changes 🛠 - Use Go 1.22 in head tests by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1305](https://togithub.com/ClickHouse/clickhouse-go/pull/1305) - Skip flaky 1127 test by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1307](https://togithub.com/ClickHouse/clickhouse-go/pull/1307) **Full Changelog**: ClickHouse/clickhouse-go@v2.24.0...v2.25.0 ### [`v2.24.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2240-2024-05-08----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.23.2...v2.24.0) #### What's Changed ##### Enhancements 🎉 - Always compress responses when the client compression is on by [@​zhkvia](https://togithub.com/zhkvia) in [https://github.com/ClickHouse/clickhouse-go/pull/1286](https://togithub.com/ClickHouse/clickhouse-go/pull/1286) - Optional flag to close query with flush by [@​hongker](https://togithub.com/hongker) in [https://github.com/ClickHouse/clickhouse-go/pull/1276](https://togithub.com/ClickHouse/clickhouse-go/pull/1276) ##### Fixes 🐛 - Fix prepare batch does not break on `values` substring in table name by [@​Wang](https://togithub.com/Wang) in [https://github.com/ClickHouse/clickhouse-go/pull/1290](https://togithub.com/ClickHouse/clickhouse-go/pull/1290) - Fix nil checks when appending slices of pointers by [@​markandrus](https://togithub.com/markandrus) in [https://github.com/ClickHouse/clickhouse-go/pull/1283](https://togithub.com/ClickHouse/clickhouse-go/pull/1283) ##### Other Changes 🛠 - Don't recreate keys from LC columns from direct stream by [@​genzgd](https://togithub.com/genzgd) in [https://github.com/ClickHouse/clickhouse-go/pull/1291](https://togithub.com/ClickHouse/clickhouse-go/pull/1291) #### New Contributors - [@​zhkvia](https://togithub.com/zhkvia) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1286](https://togithub.com/ClickHouse/clickhouse-go/pull/1286) **Full Changelog**: ClickHouse/clickhouse-go@v2.23.2...v2.24.0 ### [`v2.23.2`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2232-2024-04-25----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.23.1...v2.23.2) #### What's Changed ##### Fixes 🐛 - Fixed panic on concurrent context key map write by [@​Wang](https://togithub.com/Wang) in [https://github.com/ClickHouse/clickhouse-go/pull/1284](https://togithub.com/ClickHouse/clickhouse-go/pull/1284) ##### Other Changes 🛠 - Fix ClickHouse Terraform provider version by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1285](https://togithub.com/ClickHouse/clickhouse-go/pull/1285) #### New Contributors - [@​Wang](https://togithub.com/Wang) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1284](https://togithub.com/ClickHouse/clickhouse-go/pull/1284) **Full Changelog**: ClickHouse/clickhouse-go@v2.23.1...v2.23.2 ### [`v2.23.1`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2231-2024-04-15----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.23.0...v2.23.1) #### What's Changed ##### Fixes 🐛 - Zero-value timestamp to be formatted as toDateTime(0) in bind by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1260](https://togithub.com/ClickHouse/clickhouse-go/pull/1260) ##### Other Changes 🛠 - Update [#​1127](https://togithub.com/ClickHouse/clickhouse-go/issues/1127) test case to reproduce a progress handle when exception is thrown by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1259](https://togithub.com/ClickHouse/clickhouse-go/pull/1259) - Set max parallel for GH jobs by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1261](https://togithub.com/ClickHouse/clickhouse-go/pull/1261) - Ensure test container termination by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1274](https://togithub.com/ClickHouse/clickhouse-go/pull/1274) **Full Changelog**: ClickHouse/clickhouse-go@v2.23.0...v2.23.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Yang Song <[email protected]>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The built-in debug-log function was printing more information than the custom one could. This PR makes them on-par by providing the wrapper.
I think this can be considered backwards-compatible, but I would be happy to hear your opinion on this. This is just a debug message after all and we just prefix it with extra data.