Add Close
function to batch interface
#1566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #1558
If a
batch
falls out of scope, it's possible that the connection will stay open. If the connection is never used again, the server sees anEOF
in the query log. It starves the client and server of connections when these are left open.This function can safely be called via
defer
, which will verify that theINSERT
is completed and the connection is released back to the pool. A side effect of this is you may see some0
row inserts in the query log, but this is better than erroring.Example:
This is similar to other Go modules/structs that depend on
Close
being called for resource disposal.Checklist