Skip to content

Check for Shared database engine in can_exchange #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

tavplubix
Copy link
Member

Summary

Check for Shared database engine in can_exchange (for SharedCatalog). See https://clickhouse-inc.slack.com/archives/C03P2UB2NEB/p1748015555369729?thread_ts=1747039049.389849&cid=C03P2UB2NEB

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@mshustov mshustov requested review from BentsiLeviav and Copilot May 25, 2025 09:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for the Shared database engine in the can_exchange check to enable SharedCatalog exchanges.

  • Expanded the allowed engine list in can_exchange to include "Shared".
  • No other functional changes.
Comments suppressed due to low confidence (1)

dbt/adapters/clickhouse/impl.py:173

  • Add unit and integration tests covering the new 'Shared' engine scenario to verify that can_exchange returns True when the engine is Shared.
return ch_db and ch_db.engine in ('Atomic', 'Replicated', 'Shared')

@BentsiLeviav BentsiLeviav merged commit e34dc6b into main Jun 3, 2025
3 of 42 checks passed
@tavplubix
Copy link
Member Author

Thanks! Can we make a new release that includes this patch?

@BentsiLeviav
Copy link
Contributor

@tavplubix sure, on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants