Add digital signature/zotero config to settings iframe #12913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codewithvk
commented
Sep 19, 2025
Contributor
Author
codewithvk
left a comment
codewithvk
left a comment
There was a problem hiding this comment.
note to my self: remove unwanted logs
codewithvk
force-pushed
the
private/codewithvk/digital_sign
branch
2 times, most recently
from
5da0519 to
1fee150
Compare
codewithvk
changed the title
codewithvk
force-pushed
the
private/codewithvk/digital_sign
branch
from
4528686 to
d2352f8
Compare
codewithvk
force-pushed
the
private/codewithvk/digital_sign
branch
from
d2352f8 to
13ba388
Compare
caolanm
reviewed
Oct 8, 2025
5 tasks
codewithvk
force-pushed
the
private/codewithvk/digital_sign
branch
from
137dfc1 to
746eff2
Compare
lpranam
previously requested changes
Oct 9, 2025
Member
lpranam
left a comment
lpranam
left a comment
There was a problem hiding this comment.
I have tested the code for Zotero and it works as expected for backward compatibility.
github-project-automation
bot
moved this from To Review
to In Progress
in Collabora Online
lpranam
reviewed
Oct 10, 2025
codewithvk
force-pushed
the
private/codewithvk/digital_sign
branch
3 times, most recently
from
cee8c15 to
bd5b903
Compare
5 tasks
caolanm
approved these changes
Oct 17, 2025
Contributor
caolanm
left a comment
caolanm
left a comment
There was a problem hiding this comment.
Looks ok to me. But quikee to check some sample digital signing to confirm that that still works.
This commit adds support for configuring digital signature certificates, keys, and CA in the admin integrator settings interface. The signature configuration is stored in viewsetting.json and passed through to the document session for use in document signing. Changes include: - Add signature fields (cert, key, CA) to ViewSettings interface - Create textarea UI components for multi-line certificate input - Refactor view settings to use generic input field creation - Extract signature data from viewsetting.json and store in Session - Pass signature config through DocumentBroker to Kit process - Add signatureconfig parameter to load command - Merge signature data into userPrivateInfo for LibreOfficeKit The signature configuration follows the same pattern as existing view settings like accessibility and Zotero API key. Signed-off-by: codewithvk <[email protected]> Change-Id: I4da8748a992d8f95e3f7e782843c862277597c3d
When shifting digital signature configuration to the new settings iframe, existing users with signature credentials stored in UserPrivateInfo would lose their keys. This change ensures backward compatibility by migrating signature values from the old storage location to viewsetting.json. Signed-off-by: codewithvk <[email protected]> Change-Id: I26ce5cc115f546f8069e228c7b6ffeb347061d72
problem: After shifting to AdminIntegratorSettings zotero settings disappeared for most user as it required re entering the api key in settings. This made user think zotero was broken Signed-off-by: codewithvk <[email protected]> Change-Id: I03feaabc9d784bd30678f844047533fcda497ce6
Signed-off-by: codewithvk <[email protected]> Change-Id: I29b92e118a8a3e8ef0a95c5ca49bdc4d7ef23537
Signed-off-by: codewithvk <[email protected]> Change-Id: I196c115ffc992e19e0969f279fee11078f006462
Signed-off-by: codewithvk <[email protected]> Change-Id: If5a258d78e8cd03346a4eb178157f61a3903781b
Previously sent empty signatureconfig={} which could be problematic for
load command. Now only send signature configuration when view settings
are actually updated, eliminating unnecessary empty JSON payload.
Signed-off-by: codewithvk <[email protected]>
Change-Id: I977af57923f785f7d26c92706053cb5ba2232bd1
codewithvk
force-pushed
the
private/codewithvk/digital_sign
branch
from
bd5b903 to
c8153de
Compare
3 tasks
lpranam
changed the title
6 tasks
codewithvk
added a commit
to nextcloud/richdocuments
that referenced
this pull request
Dec 15, 2025
Since Collabora Online already supports digital signatures via the settings iframe, this patch is intended to only hide the UI inputs. The related variables will still be sent to Online through checkfileinfo, and migration cases will be handled as well. Online PR: CollaboraOnline/online#12913 Signed-off-by: codewithvk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I4da8748a992d8f95e3f7e782843c862277597c3d
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay