Skip to content

Make EmptyLatentImage follow intermediate dtype.#12974

Merged
comfyanonymous merged 1 commit intomasterfrom
comfyanonymous-patch-1
Mar 15, 2026
Merged

Make EmptyLatentImage follow intermediate dtype.#12974
comfyanonymous merged 1 commit intomasterfrom
comfyanonymous-patch-1

Conversation

@comfyanonymous
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c0c7d659-29ad-4eb6-962f-d9d693eb6b4a

📥 Commits

Reviewing files that changed from the base of the PR and between e84a200 and 86d1b00.

📒 Files selected for processing (1)
  • nodes.py

📝 Walkthrough

Walkthrough

The EmptyLatentImage class in nodes.py was refactored to remove its explicit __init__ method and the stored device reference. The generate method now retrieves the device and data type dynamically at call time using comfy.model_management.intermediate_device() and comfy.model_management.intermediate_dtype() instead of relying on a pre-computed self.device. This shifts device resolution from initialization time to execution time.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating EmptyLatentImage to use intermediate dtype instead of a stored device.
Description check ✅ Passed No description was provided; however, the title and code changes are self-explanatory and directly related to the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@comfyanonymous comfyanonymous merged commit d062bec into master Mar 15, 2026
15 checks passed
@comfyanonymous comfyanonymous deleted the comfyanonymous-patch-1 branch March 15, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant