Skip to content

Fix potential issue.#13009

Merged
comfyanonymous merged 1 commit intomasterfrom
comfyanonymous-patch-1
Mar 17, 2026
Merged

Fix potential issue.#13009
comfyanonymous merged 1 commit intomasterfrom
comfyanonymous-patch-1

Conversation

@comfyanonymous
Copy link
Copy Markdown
Member

No description provided.

@comfyanonymous comfyanonymous merged commit ca17fc8 into master Mar 17, 2026
15 of 16 checks passed
@comfyanonymous comfyanonymous deleted the comfyanonymous-patch-1 branch March 17, 2026 01:38
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 17, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The set_attr_param function in comfy/utils.py was modified to introduce a condition that clones attribute values only when the code is not operating in inference mode. Previously, the function would clone values unconditionally. This change prevents tensors created during inference from being wrapped in nn.Parameter objects while inference mode is active, addressing a scenario where wrapping such tensors could lead to unintended behavior.

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is vague and generic, using the non-descriptive term 'potential issue' without conveying what the actual problem or fix entails. Use a more specific title that describes the actual issue being fixed, such as 'Prevent cloning tensors during inference mode' or similar.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether the intended changes are documented. Add a description explaining the issue being fixed, why it matters, and how the change resolves it.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can get early access to new features in CodeRabbit.

Enable the early_access setting to enable early access features such as new models, tools, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant