Repository navigation
Skip the narration question on a computer with no microphone - #1327
Merged
Merged
Conversation
davidmckayv
requested review from
MikeRyanDev,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
November 9, 2026 02:01
Teach a Bot already says "No microphone found. Narration is off." and turns the Narration switch off on a computer with no microphone, yet Start recording still asked "Narrate while you record?" with Record with narration as its first answer. Record now asks only when a microphone is there or not known; with none it records without narration and leaves the choice unmade, so the first recording with a microphone still asks.
davidmckayv
force-pushed
the
david/rc2-no-mic-prompt
branch
from
November 9, 2026 02:17
34b6573 to
fd294ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
On a computer with no microphone, Start recording on Teach a Bot no longer opens "Narrate while you record?". It records without narration and leaves the narration choice unmade, so the first recording on a computer with a microphone still asks, exactly as before.
Why
#1314 made Teach a Bot say "No microphone found. Narration is off." and turned the Narration switch off on such a computer, but the first-time question still appeared, offering Record with narration as its primary answer. Seen on Windows with OpenBot 1.0 RC1.
The question is now gated in
useRecordingWith(app/src/components/browser/recording.tsx) on the sameuseMicrophone()state #1314 added, so every place that records (Teach a Bot on Desktop and hosted, and a Bot's browser) behaves the same. A microphone that is present or not known still gets the question.Test
app/tests/browser-page.test.tsx: in the OpenBot Desktop window, with the device-listing fake from #1314, a computer with a microphone is asked; after the microphone is unplugged, Start recording records at once withnarrate: false, no question and no preference written. Fails onrelease/1.0(no recording starts), passes with the fix.