Skip to content

Part4 update #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fredmorin wants to merge 2 commits into from
Closed

Part4 update #153

fredmorin wants to merge 2 commits into from

Conversation

@fredmorin
Copy link

@fredmorin fredmorin commented Nov 25, 2023

Following #152

Here is the PATCH or update feature implementation.

@fredmorin fredmorin mentioned this pull request Nov 25, 2023
Open
JakobMiksch
JakobMiksch reviewed Nov 27, 2023
View reviewed changes
internal/api/api.go
Comment on lines +485 to +487
"http://www.opengis.net/spec/ogcapi-features-4/1.0/conf/create-replace-delete",
"http://www.opengis.net/spec/ogcapi-features-4/1.0/conf/update",
"http://www.opengis.net/spec/ogcapi-features-4/1.0/conf/features",
Copy link
Contributor

@JakobMiksch JakobMiksch Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the linked location/website does not exist. is this intended?

Copy link
Author

@fredmorin fredmorin Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are the conformance class url from the specification: https://docs.ogc.org/DRAFTS/20-002.html#_conformance

@JakobMiksch
Copy link
Contributor

JakobMiksch commented Nov 27, 2023 •
edited
Loading

@fredmorin great initiative. Performing some requests with plain HTTP requests worked.
I tried to edit the data also via QGIS, because it apparently can edit OAF data since 3.32 (see PR qgis/QGIS#52504 ). However, QGIS did not recognise the published layer as editable. Not sure, if this is the problem of QGIS or pg_featureserv.

@fredmorin
Copy link
Author

fredmorin commented Nov 27, 2023

@JakobMiksch Thanks.
I will push a commit to fix an issue with null geometry handling and add the Location: header for the createFeature reply.

As for QGIS, I believe this may be due to the fact I haven't implemented OPTIONS.
I will test with QGIS and I am pretty sure I can figure how to make this work.

Assuming I resolve those issues, what are the chances this gets merged in the master branch ?

@fredmorin fredmorin closed this Nov 30, 2023
@fredmorin
Copy link
Author

fredmorin commented Nov 30, 2023

Closed, will continue with pr #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JakobMiksch JakobMiksch JakobMiksch left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fredmorin @JakobMiksch