fix: skip if unrecognized or unsupported uri instead of throwing errors #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 91.88% 91.86% -0.03%
==========================================
Files 77 77
Lines 10320 10407 +87
==========================================
+ Hits 9483 9560 +77
- Misses 837 847 +10 ☔ View full report in Codecov by Sentry. |
marcoslot
reviewed
Feb 24, 2025
src/parquet_copy_hook/copy_utils.rs
Outdated
| }; | ||
|
|
||
| Some(parse_uri(uri)) | ||
| ParsedUriInfo::try_from(uri).ok() |
Collaborator
There was a problem hiding this comment.
what happens to the error here? It becomes None?
Member
Author
There was a problem hiding this comment.
yep, maybe we should return Result instead of Option. It sounds better.
Collaborator
There was a problem hiding this comment.
yeh, would be good. Otherwise, this looks alright.
marcoslot
approved these changes
Feb 24, 2025
src/parquet_copy_hook/copy_utils.rs
Outdated
| }; | ||
|
|
||
| Some(parse_uri(uri)) | ||
| ParsedUriInfo::try_from(uri).ok() |
Collaborator
There was a problem hiding this comment.
yeh, would be good. Otherwise, this looks alright.
aykut-bozkurt
force-pushed
the
aykut/fix-hook-error
branch
from
6be3a74 to
7eb8369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.