fix crash with pgaudit #137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an incompatibility between pgaudit and COPY commands. pgaudit expects its own prev_standardUtility to be called before the executor permission check hook is called. However, our COPY command does not call prev_standardUtility, so pgaudit crashes. Instead, here we disable pgaudit for the duration of the COPY command. See pgaudit/pgaudit#212
An example flow to trigger crash before this PR:
After this PR, the crash won't happen but at the cost of not auditing "copy from parquet" commands.