Skip to content

Conversation

@aykut-bozkurt
Copy link
Member

@aykut-bozkurt aykut-bozkurt commented Aug 13, 2025

  • Explicitly require pg_parquet in shared_preload_libraries because we hook into Postgres utility hook,
  • Improve README.md about installation.
    • specify --features pg<version> if the pg version is not the latest supported (default) by pg_parquet.
    • specify cargo-pgrx version as the same as pgrx dependency in Cargo.toml.

Closes #68.
Closes #149.

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.89%. Comparing base (8cec92c) to head (3eee28c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   90.90%   90.89%   -0.01%     
==========================================
  Files          92       92              
  Lines       10420    10423       +3     
==========================================
+ Hits         9472     9474       +2     
- Misses        948      949       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


#[pg_guard]
pub extern "C-unwind" fn _PG_init() {
if !unsafe { pgrx::pg_sys::process_shared_preload_libraries_in_progress } {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We sometimes also put an IsBinaryUpgrade check here to avoid getting unintentionally loaded during pg_upgrade

@aykut-bozkurt aykut-bozkurt merged commit ccc963d into main Aug 13, 2025
8 of 10 checks passed
@aykut-bozkurt aykut-bozkurt deleted the aykut/explicit-shared-preload-lib branch August 13, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have to drop/create extension on every run COPY format "parquet" not recognized

3 participants