Skip to content

Conversation

@aykut-bozkurt
Copy link
Member

@aykut-bozkurt aykut-bozkurt commented Oct 28, 2024

Supports following Google Cloud Storage uri forms:

  • gs:// <bucket> / <path>

Configuration

The simplest way to configure object storage is by creating a json config file like ~/.config/gcloud/application_default_credentials.json (can be generated by gcloud auth application-default login):

$ ~/.config/gcloud/application_default_credentials.json
{
  "gcs_base_url": "gs://testbucket/test.parquet",
  "disable_oauth": false,
  "client_email": "...",
  "private_key_id": "...",
  "private_key": "..."
}

Alternatively, you can use the following environment variables when starting postgres to configure the Google Cloud Storage client:

  • GOOGLE_SERVICE_ACCOUNT_KEY: json serialized service account key
  • GOOGLE_SERVICE_ACCOUNT_PATH: an alternative location for the config file

Closes #62

@aykut-bozkurt aykut-bozkurt marked this pull request as draft October 28, 2024 10:02
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/azure-blob-storage branch from 2feb683 to 3d026b6 Compare November 9, 2024 14:26
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/google-cloud-storage branch from 048bd25 to 4a93f99 Compare November 9, 2024 14:29
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/azure-blob-storage branch 2 times, most recently from afb3c71 to 2a3061f Compare November 9, 2024 23:27
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/google-cloud-storage branch from 4a93f99 to c1ba6ad Compare November 9, 2024 23:38
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/azure-blob-storage branch from 2a3061f to 0a3281f Compare November 28, 2024 15:38
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/google-cloud-storage branch from c1ba6ad to 5d15466 Compare November 28, 2024 15:48
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/azure-blob-storage branch from 0a3281f to 80e449f Compare November 28, 2024 21:41
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/google-cloud-storage branch 2 times, most recently from b588cfd to a61b15d Compare November 28, 2024 23:00
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/azure-blob-storage branch from 80e449f to 8553677 Compare December 3, 2024 12:04
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/google-cloud-storage branch from a61b15d to f187bc4 Compare December 3, 2024 12:08
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/google-cloud-storage branch from 0c15989 to d76bf55 Compare December 16, 2024 16:17
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/azure-blob-storage branch 2 times, most recently from e0df256 to e9d0cdd Compare January 6, 2025 17:09
Base automatically changed from aykut/azure-blob-storage to main January 10, 2025 12:36
@aykut-bozkurt aykut-bozkurt marked this pull request as ready for review January 10, 2025 12:58
@codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 94.89051% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.15%. Comparing base (7f6d421) to head (f164838).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/object_store/gcs.rs 86.84% 5 Missing ⚠️
src/arrow_parquet/uri_utils.rs 80.00% 1 Missing ⚠️
src/object_store/object_store_cache.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   91.12%   91.15%   +0.03%     
==========================================
  Files          87       88       +1     
  Lines       12479    12606     +127     
==========================================
+ Hits        11371    11491     +120     
- Misses       1108     1115       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aykut-bozkurt aykut-bozkurt force-pushed the aykut/google-cloud-storage branch from dd3d157 to ec5c082 Compare January 30, 2025 09:06
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/google-cloud-storage branch 4 times, most recently from fdb69ae to f68c49e Compare March 11, 2025 09:14
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/google-cloud-storage branch from f68c49e to d6957e0 Compare March 14, 2025 12:02
@ErvalhouS
Copy link

Looking forward to this 👍

README.md Outdated
The simplest way to configure object storage is by creating a json config file like [`/tmp/gcs.json`]:

```bash
$ cat /tmp/gcs.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the default location for that file? seems unlikely

Copy link
Collaborator

@marcoslot marcoslot Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to authenticate via gcloud auth application-default login which creates ~/.config/gcloud/application_default_credentials.json, probably the former should be in the docs.

@aykut-bozkurt aykut-bozkurt force-pushed the aykut/google-cloud-storage branch from d6957e0 to d693316 Compare April 7, 2025 13:37
@aykut-bozkurt aykut-bozkurt requested a review from marcoslot April 7, 2025 13:40
README.md Outdated

#### Google Cloud Storage

The simplest way to configure object storage is by creating a json config file like [`~/.config/gcloud/application_default_credentials.json`]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth mentioning gcloud auth application-default login

@aykut-bozkurt aykut-bozkurt force-pushed the aykut/google-cloud-storage branch from d693316 to 71508de Compare April 9, 2025 13:19
@aykut-bozkurt aykut-bozkurt enabled auto-merge (squash) April 9, 2025 13:19
@aykut-bozkurt aykut-bozkurt disabled auto-merge April 9, 2025 13:20
@aykut-bozkurt aykut-bozkurt enabled auto-merge (squash) April 9, 2025 13:20
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/google-cloud-storage branch from 71508de to f164838 Compare April 9, 2025 13:21
@aykut-bozkurt aykut-bozkurt merged commit 0de2de1 into main Apr 9, 2025
6 checks passed
@aykut-bozkurt aykut-bozkurt deleted the aykut/google-cloud-storage branch April 9, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Google Cloud Storage

4 participants