Make default numeric scale 9 #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To give the integral part more room, we decided to make the default scale = 9 when the user does not specify precision and scale for numeric type. Multiplication of 2 numeric doubles the result scale and gives the integral part less digits. It is wiser to make it smaller but still useful number.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=======================================
Coverage 92.11% 92.11%
=======================================
Files 71 71
Lines 9104 9104
=======================================
Hits 8386 8386
Misses 718 718 ☔ View full report in Codecov by Sentry. |
marcoslot
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To give the integral part more room, we decided to make the default scale = 9 (16 before) when the user does not specify precision and scale for numeric type.
Multiplication of 2 numeric doubles the result scale and gives the integral part less digits. It is wiser to make it smaller but still useful number.