-
Notifications
You must be signed in to change notification settings - Fork 24
Robin pilot logging #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Robin pilot logging #550
Conversation
5218531
to
9d7e6b1
Compare
87ffdf6
to
50e9ff3
Compare
50e9ff3
to
e3b1128
Compare
e3b1128
to
d3632e1
Compare
To review this code, this is a summary of what's new compared to the pilot authentification:
|
da97b8f
to
7dc9b17
Compare
7dc9b17
to
86e715d
Compare
I'm wondering why you removed the original line number from the |
As timestamps are generated from the pilot itself (as logs are printed out), if we sort logs by timestamps, we could add the right numbering without losing space? Sorting by timestamp would actually give logs in order they were caught by a pilot, which is what we want? If for whatever reason numbering is broken, we could have shuffled logs, whereas with timestamps we are assured order is kept. |
To get the numberring it would be sufficient to define a class variable in the extended logger in the pilot and increment it every time a log statement is called. |
Updates to #511 , rebased and linked to #421