Remove ninja runtime dependency #1484
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Dao-AILab#1470 This section is for runtime dependencies and `ninja` is more necessary at build time, not at run time. I'm not sure why adding it is causing the error in the linked issue but removing it resolves the error.
|
I've met the same problem, and this works out fine for me. Thank you! |
|
Works for me as well! |
weiji14
reviewed
May 1, 2025
Co-authored-by: Wei Ji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1470
This section is for runtime dependencies and
ninjais more necessary at build time, not at run time. I'm not sure why adding it is causing the error in the linked issue but removing it resolves the error.