feat: fa3 custom ops for compatibility with PT Compile #1590
+184
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 9, 2025 18:04
Signed-off-by: liyong.0517 <[email protected]>
Signed-off-by: liyong.0517 <[email protected]>
Signed-off-by: liyong.0517 <[email protected]>
Signed-off-by: liyong.0517 <[email protected]>
Signed-off-by: liyong.0517 <[email protected]>
Signed-off-by: liyong.0517 <[email protected]>
Signed-off-by: liyong.0517 <[email protected]>
Signed-off-by: liyong.0517 <[email protected]>
Signed-off-by: liyong.0517 <[email protected]>
Signed-off-by: liyong.0517 <[email protected]>
Signed-off-by: liyong.0517 <[email protected]>
|
Thanks! Let's just assume that pytorch version is >= 2.4 to simplify the code. We will drop support for pytorch versions before that. |
Signed-off-by: zhangheng <[email protected]>
|
@tridao done |
|
@tridao any other comments？ |
|
works like charm, thx @zhangheng408 ! |
|
@tridao Can we please merge this? It would be extremely useful e.g. with SAC feature in PyTorch and it brings FA3 to parity with FA2, which is already registered as PyTorch op. |
|
@tridao Pinging again, I think it's a simple, yet very useful PR, would be great to merge it. |
|
Hey, this would be important for FA3 in Transformers, see huggingface/transformers#38972 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fa2 custom ops are supported in #1139.
add fa3 custom ops