-
Notifications
You must be signed in to change notification settings - Fork 157
✨Standardize RUM integration in Flagging SDK #3634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: flagging-dev
Are you sure you want to change the base?
Conversation
rum-events-format
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how the submodule got out of sync...
@@ -31,6 +31,9 @@ describe('evaluate', () => { | |||
expect(result).toEqual({ | |||
value: true, | |||
variant: 'variation-124', | |||
flagMetadata: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plumbing the allocationKey
through the metadata so that we have it available when tracking exposures
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## flagging-dev #3634 +/- ##
================================================
- Coverage 92.13% 92.07% -0.07%
================================================
Files 326 326
Lines 8189 8201 +12
Branches 1849 1856 +7
================================================
+ Hits 7545 7551 +6
- Misses 644 650 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/** | ||
* The site to use for the Datadog API. | ||
*/ | ||
site?: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
site
is the standard name here in the browser sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice enhancement on the integration UX
// Initialize Datadog Browser SDK | ||
datadogRum.init({ | ||
... | ||
enableExperimentalFeatures: ["feature_flags"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is no longer needed, that's what @benoit mentioned.
clientToken: 'your-client-token', | ||
rum: { | ||
sdk: datadogRum, | ||
ddFlaggingTracking: true, // Track feature flag evaluations in RUM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the idea behind putting this into the browser-sdk as a RUM action rather than wait for the new EvP track to be available?
Are we committed to cutting users off/requiring them to upgrade once the new track is ready, or do we need to support both the custom RUM action and new EvP track until all customers are upgraded to the new track (which might be never)?
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
Motivation
FFL-116
Changes
Test instructions
Checklist