Skip to content

Enable Azure infrastructure encryption #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Basanth-K
Copy link

Added properties for resource 'Microsoft.Storage/storageAccounts', to enable infrastructure encryption.

What does this PR do?

Enables infrastructure encryption for storage account provisioned using function_template.json. By default it will not be enabled. Refer to the below image.

image

This PR has the modified template which has the properties added to the resource 'Microsoft.Storage/storageAccounts', to enable infrastructure encryption.

Motivation

Observed that the current template does not enable the infrastructure encryption on storage accounts. When infrastructure encryption is enabled for a storage account, data is encrypted twice, with two different encryption algorithms and two different keys. This is a security requirement in many cases.

Refer to the Microsoft documentation.

Testing Guidelines

This template has been tested by deploying it to our Azure Subscription and the deployment succeeded with the desired results i.e., Infrastructure Encryption is enabled on the storage account. This is tested in below 2 ways.

  1. Tested the storage account deployment alone using an ARM template, with properties required for enabling infrastructure encryption. It successfully created a storage account with infrastructure encryption enabled. Refer to the below screenshot.

image

  1. Deployed the parent_template.json, which internally calls event_hub.json and function_template.json (with modified code). Deployment was successful and has given the desired results. Please refer to the below images.

image
image
image
image

Additional Notes

This PR doesn't not impact the existing PowerShell script or there will not be any impact on other resources created as part of the template. This only enables a specific property on Storage Account.

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

Added properties for resource 'Microsoft.Storage/storageAccounts', to enable infrastructure encryption.
@Basanth-K
Copy link
Author

Hi Team, Can someone please approve and run the workflows?

@Basanth-K Basanth-K changed the title Update function_template.json Enable Azure infrastructure encryption Apr 13, 2022
@Basanth-K
Copy link
Author

Hi @claudiadadamo @jvanbrie,

Can we please have the workflows approved and run? Also can we have this PR reviewed?
Incase, this is not in your purview, can you please redirect to the maintainers of this repo. Any help on this is much appreciated. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant