-
Notifications
You must be signed in to change notification settings - Fork 394
Fix:Rails Runner instrumentation #4681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 20935 Passed, 1298 Skipped, 4m 14.73s Total Time ❌ Failed Tests (1)
|
BenchmarksBenchmark execution time: 2025-05-27 22:53:57 Comparing candidate commit 1fd6d88 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics. scenario:error - error tracking with http - third_party only
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4681 +/- ##
==========================================
- Coverage 97.64% 97.64% -0.01%
==========================================
Files 1470 1470
Lines 87685 87683 -2
Branches 4544 4540 -4
==========================================
- Hits 85624 85615 -9
- Misses 2061 2068 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👏🏼
What does this PR do?
The Rails Runner instrumentation was being loaded too late, effectively not being able to create its spans.
Change log entry
Yes. The Rails Runner instrumentation has been fixed, and should now create Rails Runner spans.
How to test the change?
All changes have tests. And this time, they reflect a real Rails setup.