-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update _index.md on the runtime_id_enabled #29782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Documentation Team ReviewThe documentation team has approved this pull request. Thank you for your contribution! |
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I suggested a couple of minor formatting changes, plus:
- In the Compatibility table above, I think we should remove "Generates runtime-id granularity" from each tab now, since it's addressed in the new configuration description?
- Not strictly related but in that table we could also remove the "Support Level", just keeping it for Python since it's in Preview? (I think users should expect everything in docs to be GA unless otherwise stated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great docs! I had two optional suggestions, otherwise LGTM aside from Duncan's suggestion
@@ -163,6 +163,10 @@ Use the following environment variables to configure runtime metrics in your app | |||
: **Default**: `true` for Java, `false` for all other languages <br> | |||
**Description**: Enables the collection of runtime metrics. Metrics are sent to the Datadog agent, as configured for the instrumented application. | |||
|
|||
`DD_RUNTIME_ID_ENABLED` | |||
: **Default**: `false` for Node.js, Ruby and Python languages <br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[optional] consider inverting the definition here to make true
appear more as the intended behavior
: **Default**: `false` for Node.js, Ruby and Python languages <br> | |
: **Default**: `true` for Java, .NET, and Go; `false` for all other languages <br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see below
8db5169
to
75fabf4
Compare
Co-authored-by: Duncan Hewett <[email protected]>
Co-authored-by: Duncan Hewett <[email protected]>
Co-authored-by: Brian Marks <[email protected]>
Signed-off-by: Anna <[email protected]>
75fabf4
to
c74f05a
Compare
@@ -163,6 +157,10 @@ Use the following environment variables to configure runtime metrics in your app | |||
: **Default**: `true` for Java, `false` for all other languages <br> | |||
**Description**: Enables the collection of runtime metrics. Metrics are sent to the Datadog agent, as configured for the instrumented application. | |||
|
|||
`DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED` | |||
: **Default**: `true` for Java, `false` for Node.js, Ruby and Python. Does not exist for .NET and Go, runtime-id is always reported <br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bm1549 changed to this as .net and go just don't have the env var and it's not configurable, so itwont work if someone tries to deactivate it for these languages. Let me know if you think it's too complicated and we should just say instead:
true for Java, .NET and Go, false for all other languages.
Done both thanks, left Preview for Python as there is still the overshadowing issue that needs the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Brian Marks <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🚀
Co-authored-by: Brett Blue <[email protected]>
What does this PR do? What is the motivation?
It adds information about the runtime-id granularity possibility for nodejs/python/ruby
Merge instructions
Merge readiness: