-
-
Notifications
You must be signed in to change notification settings - Fork 672
chore: upgrade to Angular v20 + deps #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- upgraded bootstrap from 5.3.3 to 5.3.7 - upgraded dotenv from 16.4.7 to 16.5.0 - upgraded mongoose from 8.9.5 to 8.16.0 - upgraded @types/express from 4.17.21 to 4.17.23 - upgraded @types/jsonwebtoken from 9.0.7 to 9.0.10 - upgraded @types/morgan from 1.9.9 to 1.9.10 - upgraded @types/node from 20.9.0 to 22.15.29 - upgraded @types/supertest from 6.0.2 to 6.0.3 - upgraded htmlhint from 1.1.4 to 1.6.3 - upgraded nodemon from 3.1.9 to 3.1.10 - upgraded supertest from 7.0.0 to 7.1.1 - upgraded ts-jest from 29.2.5 to 29.4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Upgrades the Angular application to version 20 and aligns all dependencies and build configurations accordingly.
- Bumps Angular core and related package versions in
package.json
- Switches builder definitions in
angular.json
to the new@angular/build
targets - Converts constructor-based DI to standalone
inject()
calls and applies new@if/@for
template directives
Reviewed Changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
package.json | Updated Angular and other dependency versions |
angular.json | Replaced @angular-devkit/build-angular builders with @angular/build |
client/app/shared/toast/toast.component.html | Converted *ngIf to @if control flow directive |
client/app/shared/loading/loading.component.html | Converted *ngIf to @if control flow directive |
client/app/services/user.service.ts | Switched from constructor DI to inject(HttpClient) |
client/app/services/cat.service.ts | Switched from constructor DI to inject(HttpClient) |
client/app/services/auth.service.ts | Switched from constructor DI to multiple inject() calls |
client/app/services/auth-guard-login.service.ts | Switched from constructor DI to inject(AuthService) |
client/app/services/auth-guard-admin.service.ts | Switched from constructor DI to inject(AuthService) |
client/app/register/register.component.ts | Switched from constructor DI to multiple inject() calls |
client/app/register/register.component.html | Added autocomplete attributes on form inputs |
client/app/logout/logout.component.ts | Switched from constructor DI to inject(AuthService) |
client/app/login/login.component.ts | Switched from constructor DI to multiple inject() calls |
client/app/login/login.component.html | Added autocomplete attributes on form inputs |
client/app/cats/cats.component.ts | Switched from constructor DI to multiple inject() calls |
client/app/cats/cats.component.html | Converted *ngIf/*ngFor to @if/@for directives |
client/app/app.component.ts | Switched from constructor DI to inject() calls |
client/app/app.component.html | Converted *ngIf to @if control flow directive |
client/app/admin/admin.component.ts | Switched from constructor DI to multiple inject() calls |
client/app/admin/admin.component.html | Converted *ngIf/*ngFor to @if/@for directives |
client/app/add-cat-form/add-cat-form.component.ts | Switched from constructor DI to multiple inject() calls |
client/app/account/account.component.ts | Switched from constructor DI to multiple inject() calls |
client/app/account/account.component.html | Converted *ngIf to @if control flow directive |
Comments suppressed due to low confidence (6)
client/app/services/auth.service.ts:12
- UserService is injected here but not imported; add
import { UserService } from './user.service';
at the top of the file.
private userService = inject(UserService);
client/app/services/auth.service.ts:15
- ToastComponent is injected here but not imported; add
import { ToastComponent } from '../shared/toast/toast.component';
at the top of the file.
toast = inject(ToastComponent);
client/app/register/register.component.ts:17
- UserService is injected here but not imported; add
import { UserService } from '../services/user.service';
at the top of the file.
private userService = inject(UserService);
client/app/login/login.component.ts:14
- AuthService is injected here but not imported; add
import { AuthService } from '../services/auth.service';
at the top of the file.
private auth = inject(AuthService);
client/app/admin/admin.component.ts:16
- UserService is injected here but not imported; add
import { UserService } from '../services/user.service';
at the top of the file.
private userService = inject(UserService);
client/app/login/login.component.html:19
- [nitpick] Use
autocomplete="current-password"
on login password fields to improve browser autofill behavior and accessibility.
formControlName="password" placeholder="Password" autocomplete="password">
No description provided.