print https:// before public endpoints #1207
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionello
requested changes
Jun 2, 2025
jordanstephens
commented
Jun 30, 2025
| }, | ||
| expectedLines: []string{ | ||
| "Deployment Name Status Endpoints", | ||
| " service1 NOT_SPECIFIED https://service1", |
There was a problem hiding this comment.
@lionello what's a good example of an endpoint that doesn't have a port, but which should be prefixed with https://? I don't think that this is a good example.
assuming port-suffixed endpoints are private
jordanstephens
force-pushed
the
jordan/show-deployed-endpoints-with-protocols
branch
from
c670bdb to
5d69c71
Compare
lionello
requested changes
Jul 1, 2025
| "service1.internal", | ||
| expectedLines: []string{ | ||
| "Deployment Name Status Endpoints DomainName", | ||
| " service1 NOT_SPECIFIED https://example.com, service1.internal:80 https://example.com", |
There was a problem hiding this comment.
this can't be be right, HTTPS to 80?
There was a problem hiding this comment.
it's not https to 80. it's https to example.com.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
https://before non-internal endpoints so that they are clickable from the shell.Linked Issues
Checklist