Support some commands offline #1237
Open
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit111
reviewed
Jun 9, 2025
commit111
approved these changes
Jun 9, 2025
commit111
reviewed
Jun 9, 2025
commit111
reviewed
Jun 9, 2025
commit111
approved these changes
Jun 24, 2025
| @@ -68,6 +68,9 @@ func prettyError(err error) error { | |||
| term.Debug("Server error:", cerr) | |||
| err = errors.Unwrap(cerr) | |||
| } | |||
| if cli.IsNetworkError(err) { | |||
| return fmt.Errorf("%w; please check network settings and try again", err) | |||
There was a problem hiding this comment.
Right now it appears as:
Error: dial tcp: lookup fabric-prod1.defang.dev: no such host; please check network settings and try again
I'm a bit inclined to show the friendlier message unable to connect to Defang server %q; please check network settings and try again to the user instead of the raw error for simplicity, but this is just a matter of personal preference.
Otherwise, looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When offline (on a plane), we should allow commands that don't require login, like
defang compose config.Linked Issues
See #1111
Checklist