Add lifecycle rule to cd bucket to only keep last 10 deployment as version

[edwardrf]

Description

To prevent cd bucket to become too big.

Sample life cycle rule:

Linked Issues

Checklist

• I have performed a self-review of my code
• I have added appropriate tests
• I have updated the Defang CLI docs and/or README to reflect my changes, if necessary

[Copilot]

Pull Request Overview

This PR adds an S3 bucket lifecycle rule in the CloudFormation template to automatically expire noncurrent object versions, limiting retention by age and version count.

• Introduces a LifecycleConfiguration with a NoncurrentVersionExpiration rule.
• Configures retention to delete versions older than 10 days and keep only the latest 10 versions.

Comments suppressed due to low confidence (2)

src/pkg/clouds/aws/ecs/cfn/template.go:87

• No tests cover the new lifecycle configuration. Consider adding or updating unit tests to verify that the template includes the expected LifecycleConfiguration and expiration rules.

LifecycleConfiguration: &s3.Bucket_LifecycleConfiguration{

src/pkg/clouds/aws/ecs/cfn/template.go:87

• The project README or CLI documentation should be updated to mention the new bucket lifecycle rules so users know about automatic version cleanup.

LifecycleConfiguration: &s3.Bucket_LifecycleConfiguration{

[Copilot]

[nitpick] Extract the literal 10 into a named constant (e.g., retentionDays or maxVersions) to avoid magic numbers and simplify future updates.

Suggested change

	NoncurrentDays: 10, // Keep deployments for at least 10 days
	NewerNoncurrentVersions: ptr.Int(10), // Keep last 10 deployments
	NoncurrentDays: retentionDays, // Keep deployments for at least 10 days
	NewerNoncurrentVersions: ptr.Int(maxVersions), // Keep last 10 deployments