-
Notifications
You must be signed in to change notification settings - Fork 65
Refactor how Shader Stage is provided #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
devshgraphicsprogramming
merged 233 commits into
master
from
rework_pipeline_shader_spec_info
Jun 18, 2025
Merged
Refactor how Shader Stage is provided #887
devshgraphicsprogramming
merged 233 commits into
master
from
rework_pipeline_shader_spec_info
Jun 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d moves spec info out
# Conflicts: # src/nbl/asset/utils/CHLSLCompiler.cpp
We want to keep SShaderSpecInfo as POD
…ple dead function pass
…raphics-Programming/Nabla into rework_pipeline_shader_spec_info
This was referenced Jun 17, 2025
# Conflicts: # examples_tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined #871 and #839