Unit tests for playground-web repository #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaviiSuri
approved these changes
Oct 16, 2024
KaviiSuri
added a commit
to KaviiSuri/playground-web
that referenced
this pull request
Nov 2, 2024
…setup-ui-packages-and-tailwind-for-console * 'master' of github.com:DiceDB/playground-web: Fix docker compose file (DiceDB#77) integrate cleanup time from playground-mono (DiceDB#76) Changes to integrate rate-limit headers for `Commands left` component UI (DiceDB#67) Adding support for JSON.SET command (DiceDB#74) Unit tests for playground-web repository (DiceDB#71) fix: docker compose contexts to ensure docker compose runs
KaviiSuri
added a commit
to KaviiSuri/playground-web
that referenced
this pull request
Nov 2, 2024
…setup-ui-packages-and-tailwind-for-console * 'master' of github.com:DiceDB/playground-web: Fix docker compose file (DiceDB#77) integrate cleanup time from playground-mono (DiceDB#76) Changes to integrate rate-limit headers for `Commands left` component UI (DiceDB#67) Adding support for JSON.SET command (DiceDB#74) Unit tests for playground-web repository (DiceDB#71) fix: docker compose contexts to ensure docker compose runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created tests for
playground-web/componentsas discussed in #893(Search/Search.test.tsx)so as the change inDiceCmdsdon't hinder the functionality of tests.clipboard.navigatordirectly is not allowed (details here) so had to createsetUpClipboard()andtearDownClipboard()command.tsx->CommandPage.tsxfor improved clarity and consistency in the codebase.data-testidattributes tobutton.tsx(packages/ui/src/button.tsx) to ensure proper rendering and accessibility for testing purposes.