Draft
Conversation
psilabs-dev
reviewed
Apr 8, 2026
| $content = $c_content[1] | ||
| } | ||
|
|
||
| if ( $redis->exists($faves_id) ) { |
Contributor
There was a problem hiding this comment.
Exist check comes too late. It should come before $redis->hget($faves_id => $key); and gate updates against nonexistent stamps.
See
LANraragi/lib/LANraragi/Model/Tankoubon.pm
Line 239 in 9d6fda1
Contributor
Author
There was a problem hiding this comment.
This review should probably be moved to #1493 since this PR should be exclusively for the Frontend files.
Contributor
There was a problem hiding this comment.
Yep, just wondered why it was in draft and realized myb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just moved the Frontend code from #1493 to here. Will leave it as a draft until the other one merges.