CLI: only push a dioxus/* fallback feature if the crate being compiled depends on the dioxus crate.#5143
Merged
Conversation
depends on the `dioxus` crate.
jkelleyrtp
approved these changes
Dec 28, 2025
SilentVoid13
pushed a commit
to SilentVoid13/dioxus
that referenced
this pull request
May 21, 2026
DioxusLabs#5143) depends on the `dioxus` crate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--androidand--iosdon't work if thedioxuscrate is not a dependency #5126This allows the CLI to compile crates which do not depend on the
dioxuscrate for Android and iOS targets (for example crates which depend ondioxus_nativedirectly).Without this patch, the CLI unconditionally injects the
dioxus/mobilefeature when passing--androidor--ioswhich causes the build to fail if thedioxuscrate is not a depdendency.