Fix autofill event downcast - ignore events of the wrong type#5379
Conversation
32c5960 to
e09bb81
Compare
|
I will say, glad this fixes the bug, but I don't think the code for the html module really got any cleaner. I think we should look into using proper Rust codegen (build.rs -> html.rs) in a way that's easy to expand for other element systems like TUI / uikit. |
|
Hi! I just found out that ResizeEvent and VisibleEvent are not working on web with this patch. |
#5483 should fix this |
…Labs#5379) * fix autofill events * ignore the wrong type of event like we do in desktop * check the event type before dispatch instead of panicing on downcast * clean up conversion * remove example * pull out shared event list * pull in deserialize_raw * unified event list * prettier comment * restore test * restore alias * normal doc comments * move over comments * minimize diff * remove alias, was moved into the macro
autofill events don't show up as the right type of event. this pr adds checks for event types and ignores events we don't recognize instead of panicing
It also introduces a unified source for events and event types which deduplicates some code
Fixes #4079
Fixes #5375