Skip to content

Support IIDX 27 and 28 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

ishmael573
Copy link
Contributor

@ishmael573 ishmael573 commented Sep 24, 2022

This is an extension of #54.

Original commits are cherry-picked as-is, and my set of patches are applied as well.

Some are already commented by myself on the original PR, some are new.


To-dos:

  • duplicated song id 23070 on frontend/iidx/iidx.py
  • missing options on bemani/frontend/static/iidx-options.js

@ishmael573
Copy link
Contributor Author

ishmael573 commented Oct 10, 2022

Rebased and force-pushed.

I've also added game options for 28. Most of the options are filled, but frame and bgm are missing. Some are just copy and paste from previous version.

27's options are missing because I don't have data at the moment. But it might be trivial with bm2dx.dll and some IDA fiddling.

Furthermore, duplicate options between towel and pacemaker are removed.

@Subject38 Subject38 mentioned this pull request Oct 13, 2022
@ishmael573 ishmael573 force-pushed the iidx_hv_and_bistro branch 2 times, most recently from 7dc3126 to 4ad5a8d Compare October 25, 2022 12:43
@ishmael573
Copy link
Contributor Author

Rebased and force-pushed again.

This time, all the Black format changes made difficult to keep original two commits, so I've squashed few commits into one.
Plus, HEROIC VERSE options are added, but 27 is n-3 now. Who cares?

Quite late, but okay to go, I suppose.

@ishmael573 ishmael573 marked this pull request as ready for review October 25, 2022 12:48
@DragonMinded
Copy link
Owner

Hey, sorry about the conflicting files, but I tried at least in the music DB one to grab what you'd done as a baseline when I fixed it up to be more generic. For read, it's probably clashing with the fact that read.py now supports auto-determining the DLL version based on a set of offsets instead of one offset, which probably is messing up the qpro stuff. Also, I don't see any tests at all whatsoever. I can't take anything in that doesn't have comprehensive traffic tests, because then I can't regression test anything when I make changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants