Skip to content

Save all workspaces after Dynamo crashes #10119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2019

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Nov 6, 2019

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Per user report issue and internal report #8913. Fixing the save workflow after Dynamo crashes. Before this PR, the Save and SaveAs function both default to the currentworkspace which is not always accurate, but is true in most other cases..

After:
User will have a chance to save each workspace with pending changes
SaveWorkspacesAfterDynamoCrash

Two files should be saved as a result of this crash:
image

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

FYIs

@Dewb

@QilongTang QilongTang added the WIP label Nov 6, 2019
@mjkkirschner
Copy link
Member

@QilongTang how did you make this crash 😉 ?

@aparajit-pratap
Copy link
Contributor

@QilongTang how did you make this crash 😉 ?

I think @QilongTang typed ... in a code block to make it crash. I think it is filed as an existing issue.

@aparajit-pratap
Copy link
Contributor

aparajit-pratap commented Nov 7, 2019

I think @QilongTang typed ... in a code block to make it crash. I think it is filed as an existing issue.

Actually I'm unable to reproduce the crash.

@QilongTang
Copy link
Contributor Author

@aparajit-pratap @mjkkirschner There are steps in #8913

@QilongTang
Copy link
Contributor Author

Running self CI and ready for review

@QilongTang QilongTang added PTAL Please Take A Look 👀 and removed WIP labels Nov 8, 2019
@QilongTang
Copy link
Contributor Author

All unit tests passing

@mjkkirschner
Copy link
Member

@QilongTang this looks good to me

@mjkkirschner mjkkirschner added the LGTM Looks good to me label Nov 13, 2019
@aparajit-pratap
Copy link
Contributor

@aparajit-pratap @mjkkirschner There are steps in #8913

Fixed crash here: #10127

@aparajit-pratap
Copy link
Contributor

LGTM with the exception of one comment about making the new method internal.

@QilongTang QilongTang removed the PTAL Please Take A Look 👀 label Nov 15, 2019
@QilongTang
Copy link
Contributor Author

@aparajit-pratap Thank you, I made the API internal for now. Will merge once all checks pass

@mjkkirschner
Copy link
Member

tracked with https://jira.autodesk.com/browse/DYN-1027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error/warning/crash Issues mentioning a Dynamo error, warning or crash message LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants