-
Notifications
You must be signed in to change notification settings - Fork 654
Save all workspaces after Dynamo crashes #10119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@QilongTang how did you make this crash 😉 ? |
I think @QilongTang typed |
Actually I'm unable to reproduce the crash. |
@aparajit-pratap @mjkkirschner There are steps in #8913 |
Running self CI and ready for review |
All unit tests passing |
@QilongTang this looks good to me |
Fixed crash here: #10127 |
LGTM with the exception of one comment about making the new method internal. |
@aparajit-pratap Thank you, I made the API internal for now. Will merge once all checks pass |
tracked with https://jira.autodesk.com/browse/DYN-1027 |
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
Per user report issue and internal report #8913. Fixing the save workflow after Dynamo crashes. Before this PR, the Save and SaveAs function both default to the currentworkspace which is not always accurate, but is true in most other cases..
After:

User will have a chance to save each workspace with pending changes
Two files should be saved as a result of this crash:

Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo
FYIs
@Dewb