Skip to content

Dyn 3485 create debug mode for hiding preferences menu #11517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 24, 2021
Merged

Dyn 3485 create debug mode for hiding preferences menu #11517

merged 10 commits into from
Feb 24, 2021

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Create a new debug mode that will be used later (in other tasks) for hiding/showing the Preferences MenuItem and the Preference panel.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@Astul-Betizagasti

I added a new workflow (issue_type_predicte.yaml) that is using the ML.NET model for predicting the issue type (source repo), so If a new issue is created in the Dynamo repo this workflow will run and will predict if is a Wishlist issue or not. If is a Wishlist issue it will be labeled as "Wishlist" and then another workflow will move the issue to the DynamoWishlist repo. If the issue is incomplete or is not valid the label "NotMLEvaluated" will be added to the issue.

Also I added two scripts more, one will return the issue body in a json string and the other one will clan the issue body removing sections not used like "Dynamo Version" or "Stack Trace"
When testing the issue predicter workflow the issues labeled as Wishlist were not moved to the DynamoWishlist repo due that the "Move Issue by labels" workflow failed. There was a problem with the PAT used to label the issue, I was using the wrong one (no triggers actions).
I just added one line in the DebugModes file so this debug mode will be used once the Dynamo menu is created and also when the Preferences menu is created.
Also I added a .config file with the debug entry so i can be enabled/disabled when creating tests for the preferences panel or the menus .
@QilongTang
Copy link
Contributor

LGTM. Let's merge and move on

@QilongTang QilongTang merged commit dde9232 into DynamoDS:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants