Dyn-3640 - Recover execution after clearing cyclic dependency from graph #11896

aparajit-pratap · 2021-07-29T02:04:24Z

Purpose

DYN-3640
This fixes a bug where if there are cycles in a graph, and the cycles are fixed (cleared) on a subsequent run, one or more nodes continue to show warnings and do not execute (they continue to return null).

The solution implemented is to try to clear the isCyclic flag from the graph nodes involved in the delta execution and clear node warnings corresponding to those graph nodes before each delta execution of the graph.

TODO:

Clear cyclic dependency warning from nodes after clearing cycle
Add unit tests

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated

src/DynamoCore/Graph/Workspaces/WorkspaceModel.cs

mjkkirschner · 2021-07-29T20:06:50Z

src/Engine/ProtoScript/Runners/LiveRunner.cs

+            var assocGraph = core.DSExecutable.instrStreamList[0].dependencyGraph;
+            var graphNodes = assocGraph.GetGraphNodesAtScope(Constants.kInvalidIndex, Constants.kInvalidIndex);
+
+            foreach (var node in nodeList)


will nodeList usually be quite small?

These are only those nodes that are modified in a single delta execution run. I guess it could be a long list if the user is in manual mode and has made a large number of edits to their graph before hitting Run.

It might be worth profiling this change or monitoring the perf benchmark tests after this goes in to see if there is a significant slowdown as a result of this additional check on each delta execution.

mjkkirschner · 2021-07-29T20:06:58Z

src/Engine/ProtoScript/Runners/LiveRunner.cs

+                if (identifier == null) continue;
+
+                GraphNode rootNode = null;
+                foreach(var gNode in graphNodes)


is this all graphNodes in the entire graph?

No, graphNodes are only those that are in global scope (class index and function index = -1 or invalid index).

I can't think of a case where we can have a cycle in a single code block node scope or function definition scope as we disallow variable redefinitions in code block nodes 🤔

src/Engine/ProtoScript/Runners/LiveRunner.cs

test/DynamoCoreTests/Engine/EngineControllerTest.cs

src/Engine/ProtoCore/AssociativeGraph.cs

… node

aparajit-pratap · 2021-08-09T15:12:43Z

I reran DynamoSelfServe and it passed here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/3044/

pinzart90 · 2021-08-10T17:14:40Z

src/Engine/ProtoScript/Runners/LiveRunner.cs

+                foreach(var gNode in graphNodes)
+                {
+                    if(identifier.Value == gNode.updateNodeRefList[0].nodeList[0].symbol.name)
+                    {


are these always valid ?
gNode.updateNodeRefList[0].nodeList[0]

src/Engine/ProtoScript/Runners/LiveRunner.cs

pinzart90

2 small observations
LGTM

sm6srw

LGTM!

* Dyn 3817 exit tour window popup (DynamoDS#11918) * DYN-3817-ExitTourWindow Popup I added the UI for the Exit Tour Window, but still having some issues in the layout * DYN-3817-ExitTourWindow-Popup I created the view for the Exit Tour Window and also the functionality of showing the ExitTour ( this is shown only when one of the steps is closed so the tour is not finished - this doesn't apply for the Survey popup). A resource string was added and is related to the ExitTour content so it can be localized later. * DYN-3817-ExitTourWindow-Popup Removing code not needed in DynamoView.xaml.cs * DYN-3817-ExitTourWindow-Popup Code Review The ExitTourWindow was renamed to RealTimeInfoWindow. I reorganized the RealTimeInfoWindow so doesn't depend of a Step (then it can be used in a more generic way). I created the properties Width, Height and TextContent inside the RealTimeInfoWindow so they can be set up from outside. The TextContent property contains the text that will be shown in the popup and it can be updated on runtime. * DYN-3817-ExitTourWindow-Popup Code Issues Fixing issues produced after merging the latest changes in master branch * DYN-3817-ExitTourWindow-Popup Code Review 2 The offset hardcoded values were changed to const double, also I reorganized the way the RealTimeInfoWindow object is created. Also I added some comments in the xaml file * Dyn-3640 - Recover execution after clearing cyclic dependency from graph (DynamoDS#11896) * cleanup * minor cleanup * clear cycles from dependency graph nodes for graph runs * cleanup * update failing test * clear node warnings for cleared cycles * do not include cyclic graph node as a redefined node of another graph node * add unit tests * fix one more case * review comments * add logging to intermittent pkgloader tests (DynamoDS#11925) * update tests * update xml summary add some logging to failing tests Co-authored-by: michael kirschner <[email protected]> * pkg load test log typo (DynamoDS#11926) * update tests * update xml summary add some logging to failing tests * typo Co-authored-by: michael kirschner <[email protected]> * Update UI (DynamoDS#11932) * Update searchMethod invocation in LibraryMSWebBrowserExtension (DynamoDS#11931) * Update searchMethod invocation Update searchMethod invocation to use correct number of parameters * Update SearchDictionary.cs * Add adsk fonts to extern folder with license terms. (DynamoDS#11890) * small adjustment * align titles * add names to buttons for ui automation tests * missing button name * new font folder for use in Dynamo only * Update readme.md * add font links to about box Co-authored-by: michael kirschner <[email protected]> * check for null (DynamoDS#11930) * Prevent port measure crash (DynamoDS#11935) * CRASH: Delete node with right-click at the same time (DynamoDS#11927) * null checks * Add unit test * Fix For Loading Json File (DynamoDS#11934) * Fix For Loading Json File During the testing of the task https://jira.autodesk.com/browse/DYN-3817 Aabishkar reported that when trying to open the "Get Started" tour a message appear saying Could not find a part of the path 'C:\Windows\system32\UI\GuidedTour\dynamo_guides.json' Then I modified the code that is loading the json,file, in the past was a relative path and now we are using an absolute path. * Fix For Loading Json File Instead to have the json file path in the GuidesManager constructor I created two public properties that will contains the assembly path execution and the JSON files guides path, so we can verify in the unit testing that this paths exists and if the Guide will be created correctly. Also I added a unit test that will validate that the json guides file exists and that the Guides can be created. * Handle crash due to save path being too long Co-authored-by: Roberto T <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: michael kirschner <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Ashish Aggarwal <[email protected]>

* initial commit * Use CLRDLLModule * Refactoring * add hosts flag and other additions to frompackage * 🧹🧹 * Update Program.cs * clean up + handle overloads * 🧹 * Update AssemblyHandler.cs * too many things 🤯 * Save images instead of embedding * comment updates * add support for .ds files * comments + move to tools folder * add reference to RestSharp - need to create PackageUploadRequestBody * Update FromPackageFolderCommand.cs * 🧹 * Remove logger * remove unused using * Update FromDirectoryOptions.cs * Update AssemblyHandler.cs * Change project type + add test project * remove old files * use flag to specify ReflectionContext * few comment updates * Update DocumentationBrowserViewExtensionTests.cs * ds file fixes * fix add isReflection flag FFIMethodAtribute * First pass at comments * Update MarkdownHandler.cs * 2nd pass on comments * Update MarkdownHandler.cs * help text updates * update licence * comments * add reflection context object type check to CLRDLLModule * Use IconName to get the type FullName from a NodeModelSearchElement + other clean ups * get baseType with overloads * Load dynamo dlls from main bin folder + fix overload lookup * Update DocumentationBrowserViewExtensionTests.cs * fix issue with protogeometry format load error put clr into reflection mode when importing DS files fix classname for generated ds docs * remove unused * remove test project * comment cleanups * merge license (#31) Co-authored-by: michael kirschner <[email protected]> * move LayoutSpecification types to DynamoCore with type forward (#30) Co-authored-by: michael kirschner <[email protected]> * add new flag -g to compress gifs add gif compression by quantization to 32k colors in debug leave console open until readline for easy log reading * typo * try to resolve merge conflicts with dynamo master (#33) * Dyn 3817 exit tour window popup (#11918) * DYN-3817-ExitTourWindow Popup I added the UI for the Exit Tour Window, but still having some issues in the layout * DYN-3817-ExitTourWindow-Popup I created the view for the Exit Tour Window and also the functionality of showing the ExitTour ( this is shown only when one of the steps is closed so the tour is not finished - this doesn't apply for the Survey popup). A resource string was added and is related to the ExitTour content so it can be localized later. * DYN-3817-ExitTourWindow-Popup Removing code not needed in DynamoView.xaml.cs * DYN-3817-ExitTourWindow-Popup Code Review The ExitTourWindow was renamed to RealTimeInfoWindow. I reorganized the RealTimeInfoWindow so doesn't depend of a Step (then it can be used in a more generic way). I created the properties Width, Height and TextContent inside the RealTimeInfoWindow so they can be set up from outside. The TextContent property contains the text that will be shown in the popup and it can be updated on runtime. * DYN-3817-ExitTourWindow-Popup Code Issues Fixing issues produced after merging the latest changes in master branch * DYN-3817-ExitTourWindow-Popup Code Review 2 The offset hardcoded values were changed to const double, also I reorganized the way the RealTimeInfoWindow object is created. Also I added some comments in the xaml file * Dyn-3640 - Recover execution after clearing cyclic dependency from graph (#11896) * cleanup * minor cleanup * clear cycles from dependency graph nodes for graph runs * cleanup * update failing test * clear node warnings for cleared cycles * do not include cyclic graph node as a redefined node of another graph node * add unit tests * fix one more case * review comments * add logging to intermittent pkgloader tests (#11925) * update tests * update xml summary add some logging to failing tests Co-authored-by: michael kirschner <[email protected]> * pkg load test log typo (#11926) * update tests * update xml summary add some logging to failing tests * typo Co-authored-by: michael kirschner <[email protected]> * Update UI (#11932) * Update searchMethod invocation in LibraryMSWebBrowserExtension (#11931) * Update searchMethod invocation Update searchMethod invocation to use correct number of parameters * Update SearchDictionary.cs * Add adsk fonts to extern folder with license terms. (#11890) * small adjustment * align titles * add names to buttons for ui automation tests * missing button name * new font folder for use in Dynamo only * Update readme.md * add font links to about box Co-authored-by: michael kirschner <[email protected]> * check for null (#11930) * Prevent port measure crash (#11935) * CRASH: Delete node with right-click at the same time (#11927) * null checks * Add unit test * Fix For Loading Json File (#11934) * Fix For Loading Json File During the testing of the task https://jira.autodesk.com/browse/DYN-3817 Aabishkar reported that when trying to open the "Get Started" tour a message appear saying Could not find a part of the path 'C:\Windows\system32\UI\GuidedTour\dynamo_guides.json' Then I modified the code that is loading the json,file, in the past was a relative path and now we are using an absolute path. * Fix For Loading Json File Instead to have the json file path in the GuidesManager constructor I created two public properties that will contains the assembly path execution and the JSON files guides path, so we can verify in the unit testing that this paths exists and if the Guide will be created correctly. Also I added a unit test that will validate that the json guides file exists and that the Guides can be created. * Handle crash due to save path being too long Co-authored-by: Roberto T <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: michael kirschner <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Ashish Aggarwal <[email protected]> * revert changes to clrdllmodule * this builds * remove reflection extensions * add dyf folder exists check * resolve all reference paths remove metadata references * comments * add image magick to license files * add readme * add known issues section * more readme tweaks * add verbose mode and some logging when scanning dlls add console colors for dictionary related errors update readme * add findings to known issues * review comments move ilibraryviewcustomization as well to dynamocore * review comments Co-authored-by: SHKnudsen <[email protected]> Co-authored-by: michael kirschner <[email protected]> Co-authored-by: Roberto T <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Ashish Aggarwal <[email protected]>

* initial commit * Use CLRDLLModule * Refactoring * add hosts flag and other additions to frompackage * 🧹🧹 * Update Program.cs * clean up + handle overloads * 🧹 * Update AssemblyHandler.cs * too many things 🤯 * Save images instead of embedding * comment updates * add support for .ds files * comments + move to tools folder * add reference to RestSharp - need to create PackageUploadRequestBody * Update FromPackageFolderCommand.cs * 🧹 * Remove logger * remove unused using * Update FromDirectoryOptions.cs * Update AssemblyHandler.cs * Change project type + add test project * remove old files * use flag to specify ReflectionContext * few comment updates * Update DocumentationBrowserViewExtensionTests.cs * ds file fixes * fix add isReflection flag FFIMethodAtribute * First pass at comments * Update MarkdownHandler.cs * 2nd pass on comments * Update MarkdownHandler.cs * help text updates * update licence * comments * add reflection context object type check to CLRDLLModule * Use IconName to get the type FullName from a NodeModelSearchElement + other clean ups * get baseType with overloads * Load dynamo dlls from main bin folder + fix overload lookup * Update DocumentationBrowserViewExtensionTests.cs * fix issue with protogeometry format load error put clr into reflection mode when importing DS files fix classname for generated ds docs * remove unused * remove test project * unit tests first commit * Update Program.cs * comment cleanups * merge license (#31) Co-authored-by: michael kirschner <[email protected]> * move LayoutSpecification types to DynamoCore with type forward (#30) Co-authored-by: michael kirschner <[email protected]> * add new flag -g to compress gifs add gif compression by quantization to 32k colors in debug leave console open until readline for easy log reading * typo * try to resolve merge conflicts with dynamo master (#33) * Dyn 3817 exit tour window popup (#11918) * DYN-3817-ExitTourWindow Popup I added the UI for the Exit Tour Window, but still having some issues in the layout * DYN-3817-ExitTourWindow-Popup I created the view for the Exit Tour Window and also the functionality of showing the ExitTour ( this is shown only when one of the steps is closed so the tour is not finished - this doesn't apply for the Survey popup). A resource string was added and is related to the ExitTour content so it can be localized later. * DYN-3817-ExitTourWindow-Popup Removing code not needed in DynamoView.xaml.cs * DYN-3817-ExitTourWindow-Popup Code Review The ExitTourWindow was renamed to RealTimeInfoWindow. I reorganized the RealTimeInfoWindow so doesn't depend of a Step (then it can be used in a more generic way). I created the properties Width, Height and TextContent inside the RealTimeInfoWindow so they can be set up from outside. The TextContent property contains the text that will be shown in the popup and it can be updated on runtime. * DYN-3817-ExitTourWindow-Popup Code Issues Fixing issues produced after merging the latest changes in master branch * DYN-3817-ExitTourWindow-Popup Code Review 2 The offset hardcoded values were changed to const double, also I reorganized the way the RealTimeInfoWindow object is created. Also I added some comments in the xaml file * Dyn-3640 - Recover execution after clearing cyclic dependency from graph (#11896) * cleanup * minor cleanup * clear cycles from dependency graph nodes for graph runs * cleanup * update failing test * clear node warnings for cleared cycles * do not include cyclic graph node as a redefined node of another graph node * add unit tests * fix one more case * review comments * add logging to intermittent pkgloader tests (#11925) * update tests * update xml summary add some logging to failing tests Co-authored-by: michael kirschner <[email protected]> * pkg load test log typo (#11926) * update tests * update xml summary add some logging to failing tests * typo Co-authored-by: michael kirschner <[email protected]> * Update UI (#11932) * Update searchMethod invocation in LibraryMSWebBrowserExtension (#11931) * Update searchMethod invocation Update searchMethod invocation to use correct number of parameters * Update SearchDictionary.cs * Add adsk fonts to extern folder with license terms. (#11890) * small adjustment * align titles * add names to buttons for ui automation tests * missing button name * new font folder for use in Dynamo only * Update readme.md * add font links to about box Co-authored-by: michael kirschner <[email protected]> * check for null (#11930) * Prevent port measure crash (#11935) * CRASH: Delete node with right-click at the same time (#11927) * null checks * Add unit test * Fix For Loading Json File (#11934) * Fix For Loading Json File During the testing of the task https://jira.autodesk.com/browse/DYN-3817 Aabishkar reported that when trying to open the "Get Started" tour a message appear saying Could not find a part of the path 'C:\Windows\system32\UI\GuidedTour\dynamo_guides.json' Then I modified the code that is loading the json,file, in the past was a relative path and now we are using an absolute path. * Fix For Loading Json File Instead to have the json file path in the GuidesManager constructor I created two public properties that will contains the assembly path execution and the JSON files guides path, so we can verify in the unit testing that this paths exists and if the Guide will be created correctly. Also I added a unit test that will validate that the json guides file exists and that the Guides can be created. * Handle crash due to save path being too long Co-authored-by: Roberto T <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: michael kirschner <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Ashish Aggarwal <[email protected]> * revert changes to clrdllmodule * this builds * remove reflection extensions * Update NodeConstructionTests.cs * add dyf folder exists check * update tests * Update NodeDocumentationMarkdownGeneratorTests.csproj * clean up * Update NodeConstructionTests.cs * resolve all reference paths remove metadata references * comments * add image magick to license files * change package in test * add readme * add known issues section * more readme tweaks * add verbose mode and some logging when scanning dlls add console colors for dictionary related errors update readme * add findings to known issues * merge fix * review comments move ilibraryviewcustomization as well to dynamocore * fix bug if package is missing bin folder fix bug naming custom node .md files with only category name add test dictionary and extract layout spec remove if node and add refactored if node to test files tests should resolve assemblies from tools bin folder and look for other dlls in core dynam bin output tests to bin folder, but not tool * set function type correcty for global functions set classname on generated .md files correctly on global functions add test for ds files * review comments * add image compression tests fix gif compression if resulting gif is larger than original. * add ref flag test ref flag should be optional * add tests for loading from fallback paths * generate more docs for assemblies in nodes folder * revert version * use mslib assembly instead of libview * try to cleanup hanging dialog from linter test Co-authored-by: SHKnudsen <[email protected]> Co-authored-by: michael kirschner <[email protected]> Co-authored-by: Roberto T <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Ashish Aggarwal <[email protected]>

* initial commit * Use CLRDLLModule * Refactoring * add hosts flag and other additions to frompackage * 🧹🧹 * Update Program.cs * clean up + handle overloads * 🧹 * Update AssemblyHandler.cs * too many things 🤯 * Save images instead of embedding * comment updates * add support for .ds files * comments + move to tools folder * add reference to RestSharp - need to create PackageUploadRequestBody * Update FromPackageFolderCommand.cs * 🧹 * Remove logger * remove unused using * Update FromDirectoryOptions.cs * Update AssemblyHandler.cs * Change project type + add test project * remove old files * use flag to specify ReflectionContext * few comment updates * Update DocumentationBrowserViewExtensionTests.cs * ds file fixes * fix add isReflection flag FFIMethodAtribute * First pass at comments * Update MarkdownHandler.cs * 2nd pass on comments * Update MarkdownHandler.cs * help text updates * update licence * comments * add reflection context object type check to CLRDLLModule * Use IconName to get the type FullName from a NodeModelSearchElement + other clean ups * get baseType with overloads * Load dynamo dlls from main bin folder + fix overload lookup * Update DocumentationBrowserViewExtensionTests.cs * fix issue with protogeometry format load error put clr into reflection mode when importing DS files fix classname for generated ds docs * remove unused * remove test project * unit tests first commit * Update Program.cs * comment cleanups * merge license (#31) Co-authored-by: michael kirschner <[email protected]> * move LayoutSpecification types to DynamoCore with type forward (#30) Co-authored-by: michael kirschner <[email protected]> * add new flag -g to compress gifs add gif compression by quantization to 32k colors in debug leave console open until readline for easy log reading * typo * try to resolve merge conflicts with dynamo master (#33) * Dyn 3817 exit tour window popup (#11918) * DYN-3817-ExitTourWindow Popup I added the UI for the Exit Tour Window, but still having some issues in the layout * DYN-3817-ExitTourWindow-Popup I created the view for the Exit Tour Window and also the functionality of showing the ExitTour ( this is shown only when one of the steps is closed so the tour is not finished - this doesn't apply for the Survey popup). A resource string was added and is related to the ExitTour content so it can be localized later. * DYN-3817-ExitTourWindow-Popup Removing code not needed in DynamoView.xaml.cs * DYN-3817-ExitTourWindow-Popup Code Review The ExitTourWindow was renamed to RealTimeInfoWindow. I reorganized the RealTimeInfoWindow so doesn't depend of a Step (then it can be used in a more generic way). I created the properties Width, Height and TextContent inside the RealTimeInfoWindow so they can be set up from outside. The TextContent property contains the text that will be shown in the popup and it can be updated on runtime. * DYN-3817-ExitTourWindow-Popup Code Issues Fixing issues produced after merging the latest changes in master branch * DYN-3817-ExitTourWindow-Popup Code Review 2 The offset hardcoded values were changed to const double, also I reorganized the way the RealTimeInfoWindow object is created. Also I added some comments in the xaml file * Dyn-3640 - Recover execution after clearing cyclic dependency from graph (#11896) * cleanup * minor cleanup * clear cycles from dependency graph nodes for graph runs * cleanup * update failing test * clear node warnings for cleared cycles * do not include cyclic graph node as a redefined node of another graph node * add unit tests * fix one more case * review comments * add logging to intermittent pkgloader tests (#11925) * update tests * update xml summary add some logging to failing tests Co-authored-by: michael kirschner <[email protected]> * pkg load test log typo (#11926) * update tests * update xml summary add some logging to failing tests * typo Co-authored-by: michael kirschner <[email protected]> * Update UI (#11932) * Update searchMethod invocation in LibraryMSWebBrowserExtension (#11931) * Update searchMethod invocation Update searchMethod invocation to use correct number of parameters * Update SearchDictionary.cs * Add adsk fonts to extern folder with license terms. (#11890) * small adjustment * align titles * add names to buttons for ui automation tests * missing button name * new font folder for use in Dynamo only * Update readme.md * add font links to about box Co-authored-by: michael kirschner <[email protected]> * check for null (#11930) * Prevent port measure crash (#11935) * CRASH: Delete node with right-click at the same time (#11927) * null checks * Add unit test * Fix For Loading Json File (#11934) * Fix For Loading Json File During the testing of the task https://jira.autodesk.com/browse/DYN-3817 Aabishkar reported that when trying to open the "Get Started" tour a message appear saying Could not find a part of the path 'C:\Windows\system32\UI\GuidedTour\dynamo_guides.json' Then I modified the code that is loading the json,file, in the past was a relative path and now we are using an absolute path. * Fix For Loading Json File Instead to have the json file path in the GuidesManager constructor I created two public properties that will contains the assembly path execution and the JSON files guides path, so we can verify in the unit testing that this paths exists and if the Guide will be created correctly. Also I added a unit test that will validate that the json guides file exists and that the Guides can be created. * Handle crash due to save path being too long Co-authored-by: Roberto T <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: michael kirschner <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Ashish Aggarwal <[email protected]> * revert changes to clrdllmodule * this builds * remove reflection extensions * Update NodeConstructionTests.cs * add dyf folder exists check * update tests * Update NodeDocumentationMarkdownGeneratorTests.csproj * clean up * Update NodeConstructionTests.cs * resolve all reference paths remove metadata references * comments * add image magick to license files * change package in test * add readme * add known issues section * more readme tweaks * add verbose mode and some logging when scanning dlls add console colors for dictionary related errors update readme * add findings to known issues * merge fix * review comments move ilibraryviewcustomization as well to dynamocore * fix bug if package is missing bin folder fix bug naming custom node .md files with only category name add test dictionary and extract layout spec remove if node and add refactored if node to test files tests should resolve assemblies from tools bin folder and look for other dlls in core dynam bin output tests to bin folder, but not tool * set function type correcty for global functions set classname on generated .md files correctly on global functions add test for ds files * review comments * add image compression tests fix gif compression if resulting gif is larger than original. * add ref flag test ref flag should be optional * add tests for loading from fallback paths * generate more docs for assemblies in nodes folder * revert version * use mslib assembly instead of libview * try to cleanup hanging dialog from linter test * fix typo and test Co-authored-by: SHKnudsen <[email protected]> Co-authored-by: michael kirschner <[email protected]> Co-authored-by: Roberto T <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Ashish Aggarwal <[email protected]>

aparajit-pratap added 4 commits July 22, 2021 12:13

cleanup

b1f93ff

Merge branch 'master' of github.com:DynamoDS/Dynamo into dyn-3640

e6d13cb

minor cleanup

92668f3

clear cycles from dependency graph nodes for graph runs

911eebe

aparajit-pratap added the WIP label Jul 29, 2021

aparajit-pratap commented Jul 29, 2021

View reviewed changes

src/DynamoCore/Graph/Workspaces/WorkspaceModel.cs Show resolved Hide resolved

aparajit-pratap added 2 commits July 28, 2021 22:12

cleanup

a1991d8

update failing test

cab16c9

aparajit-pratap changed the title ~~[WIP] Dyn-3640~~ [WIP] Dyn-3640 - Recover execution after clearing cyclic dependency from graph Jul 29, 2021

mjkkirschner reviewed Jul 29, 2021

View reviewed changes

src/Engine/ProtoScript/Runners/LiveRunner.cs Outdated Show resolved Hide resolved

mjkkirschner reviewed Jul 29, 2021

View reviewed changes

test/DynamoCoreTests/Engine/EngineControllerTest.cs Show resolved Hide resolved

mjkkirschner reviewed Jul 29, 2021

View reviewed changes

src/Engine/ProtoCore/AssociativeGraph.cs Show resolved Hide resolved

aparajit-pratap added 6 commits July 30, 2021 18:01

Merge branch 'master' of github.com:DynamoDS/Dynamo into dyn-3640

2b6042f

Merge branch 'master' of github.com:DynamoDS/Dynamo into dyn-3640

de95c61

clear node warnings for cleared cycles

9b8979a

do not include cyclic graph node as a redefined node of another graph…

857df3b

… node

add unit tests

907cc81

fix one more case

4943f08

aparajit-pratap changed the title ~~[WIP] Dyn-3640 - Recover execution after clearing cyclic dependency from graph~~ Dyn-3640 - Recover execution after clearing cyclic dependency from graph Aug 8, 2021

aparajit-pratap added PTAL Please Take A Look 👀 and removed WIP labels Aug 8, 2021

mjkkirschner approved these changes Aug 10, 2021

View reviewed changes

pinzart90 reviewed Aug 10, 2021

View reviewed changes

src/Engine/ProtoScript/Runners/LiveRunner.cs Outdated Show resolved Hide resolved

pinzart90 approved these changes Aug 10, 2021

View reviewed changes

review comments

850e915

aparajit-pratap merged commit fd1154d into DynamoDS:master Aug 10, 2021

aparajit-pratap deleted the dyn-3640 branch August 10, 2021 19:01

sm6srw approved these changes Aug 10, 2021

View reviewed changes

aparajit-pratap mentioned this pull request Aug 17, 2021

[Spike] perform static cyclic dependency detection before each graph run #11940

Draft

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dyn-3640 - Recover execution after clearing cyclic dependency from graph #11896

Dyn-3640 - Recover execution after clearing cyclic dependency from graph #11896

Uh oh!

aparajit-pratap commented Jul 29, 2021 •

edited

Loading

Uh oh!

Uh oh!

mjkkirschner Jul 29, 2021

Uh oh!

aparajit-pratap Jul 30, 2021

Uh oh!

aparajit-pratap Jul 30, 2021

Uh oh!

sm6srw Aug 4, 2021

Uh oh!

mjkkirschner Jul 29, 2021 •

edited

Loading

Uh oh!

aparajit-pratap Jul 30, 2021 •

edited

Loading

Uh oh!

aparajit-pratap Jul 30, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aparajit-pratap commented Aug 9, 2021

Uh oh!

pinzart90 Aug 10, 2021

Uh oh!

aparajit-pratap Aug 10, 2021

Uh oh!

Uh oh!

pinzart90 left a comment

Uh oh!

sm6srw left a comment

Uh oh!

Uh oh!

Dyn-3640 - Recover execution after clearing cyclic dependency from graph #11896

Dyn-3640 - Recover execution after clearing cyclic dependency from graph #11896

Uh oh!

Conversation

aparajit-pratap commented Jul 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Declarations

Uh oh!

Uh oh!

mjkkirschner Jul 29, 2021

Choose a reason for hiding this comment

Uh oh!

aparajit-pratap Jul 30, 2021

Choose a reason for hiding this comment

Uh oh!

aparajit-pratap Jul 30, 2021

Choose a reason for hiding this comment

Uh oh!

sm6srw Aug 4, 2021

Choose a reason for hiding this comment

Uh oh!

mjkkirschner Jul 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aparajit-pratap Jul 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aparajit-pratap Jul 30, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aparajit-pratap commented Aug 9, 2021

Uh oh!

pinzart90 Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

aparajit-pratap Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pinzart90 left a comment

Choose a reason for hiding this comment

Uh oh!

sm6srw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aparajit-pratap commented Jul 29, 2021 •

edited

Loading

mjkkirschner Jul 29, 2021 •

edited

Loading

aparajit-pratap Jul 30, 2021 •

edited

Loading