Skip to content

2.13.1 fix ui hang when concurrent run and save. #12570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

mjkkirschner
Copy link
Member

cherry pick:
#12564

mjkkirschner and others added 3 commits January 21, 2022 16:27
…empt 1 (DynamoDS#12564)

* attempt 1, this works but seems odd.

* switch executingTask for RunEnabled

* put external files back in wsm

* int to private

* remove usings

* revert change

* revert change

Co-authored-by: michael kirschner <[email protected]>
@mjkkirschner mjkkirschner added this to the 2.13.1 milestone Jan 21, 2022
@mjkkirschner
Copy link
Member Author

tests are running.

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you also have some auto-formatting add-in installed?

@mjkkirschner
Copy link
Member Author

I formatted with visual studio at some point 😢

@QilongTang
Copy link
Contributor

I formatted with visual studio at some point 😢

Oh no worries. I scanned through the whole PR and found it's purely about removing the heartbeat which is good

@mjkkirschner
Copy link
Member Author

there is another change @QilongTang -
if (this is HomeWorkspaceModel homeWorkspaceModel && homeWorkspaceModel.RunSettings.RunEnabled)

@mjkkirschner
Copy link
Member Author

tests passed, merging.

@mjkkirschner mjkkirschner merged commit 004c5d1 into DynamoDS:RC2.13.1_master Jan 21, 2022
@mjkkirschner mjkkirschner deleted the 2131uilock branch January 21, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants