Skip to content

DYN-4254 Package labels are not aligned #12692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Conversation

sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Mar 14, 2022

Purpose

DYN-4254 Package labels are not aligned

This pull request does:

  • Increase minimum width on the version field to 70.

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Preferences->Package Manager->Installed Packages now format package labels properly when version strings are long.

@mjkkirschner
Copy link
Member

hmm, so this will work except if the version numbers are very long I guess?

@sm6srw
Copy link
Contributor Author

sm6srw commented Mar 14, 2022

hmm, so this will work except if the version numbers are very long I guess?

Correct. Yes, but it looks like those are not common. Nothing will break but it will look funny. I was considering something more advanced but I opted to do this instead eg make it even less common.

@mjkkirschner mjkkirschner self-requested a review March 14, 2022 18:05
@sm6srw sm6srw merged commit 61fac94 into DynamoDS:master Mar 14, 2022
@sm6srw sm6srw deleted the DYN-4254 branch March 14, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants