-
Notifications
You must be signed in to change notification settings - Fork 654
DYN-5286-MLNodeAutocomplete Adding Analytics #13581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-5286-MLNodeAutocomplete Adding Analytics #13581
Conversation
I added the code for TrackEvent in 4 places: - NodeAutoCompleteSearchControl.xaml.cs - when clicking the Low Confidence combobox for displaying the list of nodes. - NodeAutoCompleteSearchViewModel.cs - when the Node Autocomplete is raised using the Recommented nodes option or the Object Types option. - PreferencesView.xaml.cs when the Slider Confidence Level is updated. And finally I've added additional Actions in IAnalyticsClient.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the test is added.
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
@reddyashish I got confused, do I need to add a test? |
Removed the Actions added in IAnalyticsClient.cs so we can re-use the existing ones (so the method calls were also updated). Added Analytics track events in the Preferences panel when the NodeAutocomplete is se to ML Recomentations or Object Type. The ExportSettings option and ImportSettings option were renamed to Export and Import (so the method calls were also updated).
Analytics.TrackEvent( | ||
Actions.Show, | ||
Categories.NodeAutoCompleteOperations, | ||
nameof(NodeAutocompleteSuggestion.ObjectType)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake, I thought this is the code flip the mode but this is the actual display code. Updated and I will add tracking where user can flip mode within node autocomplete UI
Added tracking for case where we display no recommendation or could not fetch results. LGTM. @RobertGlobant20 Please update the corresponding PR in Analytics.Net repo. |
* DYN-5286-MLNodeAutocomplete-Analytics I added the code for TrackEvent in 4 places: - NodeAutoCompleteSearchControl.xaml.cs - when clicking the Low Confidence combobox for displaying the list of nodes. - NodeAutoCompleteSearchViewModel.cs - when the Node Autocomplete is raised using the Recommented nodes option or the Object Types option. - PreferencesView.xaml.cs when the Slider Confidence Level is updated. And finally I've added additional Actions in IAnalyticsClient.cs * DYN-5286-MLNodeAutocomplete-Analytics CodeReview1 Removed the Actions added in IAnalyticsClient.cs so we can re-use the existing ones (so the method calls were also updated). Added Analytics track events in the Preferences panel when the NodeAutocomplete is se to ML Recomentations or Object Type. The ExportSettings option and ImportSettings option were renamed to Export and Import (so the method calls were also updated). * Update * update * Update Co-authored-by: Aaron (Qilong) <[email protected]>
* Fix CustomNode view layout after it is saved. (#13585) * Fix CustomNode views after it is saved. * Add test * Update WorkspaceSaving.cs * Single quote to double quote in js call functions (#13586) * DYN-5286-MLNodeAutocomplete Adding Analytics (#13581) * DYN-5286-MLNodeAutocomplete-Analytics I added the code for TrackEvent in 4 places: - NodeAutoCompleteSearchControl.xaml.cs - when clicking the Low Confidence combobox for displaying the list of nodes. - NodeAutoCompleteSearchViewModel.cs - when the Node Autocomplete is raised using the Recommented nodes option or the Object Types option. - PreferencesView.xaml.cs when the Slider Confidence Level is updated. And finally I've added additional Actions in IAnalyticsClient.cs * DYN-5286-MLNodeAutocomplete-Analytics CodeReview1 Removed the Actions added in IAnalyticsClient.cs so we can re-use the existing ones (so the method calls were also updated). Added Analytics track events in the Preferences panel when the NodeAutocomplete is se to ML Recomentations or Object Type. The ExportSettings option and ImportSettings option were renamed to Export and Import (so the method calls were also updated). * Update * update * Update Co-authored-by: Aaron (Qilong) <[email protected]> * DYN-5426 Setting different font size when the height of the library is smaller (#13578) * Setting different font size when the height is smaller * calculate the font size based on the screen height Co-authored-by: reddyashish <[email protected]> Co-authored-by: filipeotero <[email protected]> Co-authored-by: Roberto T <[email protected]>
Purpose
Adding Analytics for ML Node Autocomplete
I added the code for TrackEvent in 4 places:
(I'm still missing local test)
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Adding Analytics for ML Node Autocomplete
Reviewers
@QilongTang
FYIs
@reddyashish