Skip to content

DYN-5286-MLNodeAutocomplete Adding Analytics #13581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 1, 2022
Merged

DYN-5286-MLNodeAutocomplete Adding Analytics #13581

merged 5 commits into from
Dec 1, 2022

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Adding Analytics for ML Node Autocomplete
I added the code for TrackEvent in 4 places:

  • NodeAutoCompleteSearchControl.xaml.cs - when clicking the Low Confidence combobox for displaying the list of nodes.
  • NodeAutoCompleteSearchViewModel.cs - when the Node Autocomplete is raised using the Recommented nodes option or the Object Types option.
  • PreferencesView.xaml.cs when the Slider Confidence Level is updated. And finally I've added additional Actions in IAnalyticsClient.cs
    (I'm still missing local test)

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Adding Analytics for ML Node Autocomplete

Reviewers

@QilongTang

FYIs

@reddyashish

I added the code for TrackEvent in 4 places:
- NodeAutoCompleteSearchControl.xaml.cs - when clicking the Low Confidence combobox for displaying the list of nodes.
- NodeAutoCompleteSearchViewModel.cs - when the Node Autocomplete is raised using the Recommented nodes option or the Object Types option.
- PreferencesView.xaml.cs when the Slider Confidence Level is updated.
And finally I've added additional Actions in IAnalyticsClient.cs
@reddyashish reddyashish added this to the 2.17.0 milestone Nov 30, 2022
Copy link
Contributor

@reddyashish reddyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the test is added.

@RobertGlobant20
Copy link
Contributor Author

LGTM once the test is added.

@reddyashish I got confused, do I need to add a test?

RobertGlobant20 and others added 2 commits November 30, 2022 15:24
Removed the Actions added in IAnalyticsClient.cs so we can re-use the existing ones (so the method calls were also updated).
Added Analytics track events in the Preferences panel when the NodeAutocomplete is se to ML Recomentations or Object Type.
The ExportSettings option and ImportSettings option were renamed to Export and Import (so the method calls were also updated).
Analytics.TrackEvent(
Actions.Show,
Categories.NodeAutoCompleteOperations,
nameof(NodeAutocompleteSuggestion.ObjectType));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, I thought this is the code flip the mode but this is the actual display code. Updated and I will add tracking where user can flip mode within node autocomplete UI

@QilongTang
Copy link
Contributor

Added tracking for case where we display no recommendation or could not fetch results. LGTM. @RobertGlobant20 Please update the corresponding PR in Analytics.Net repo.

@QilongTang QilongTang merged commit a8eb4a9 into DynamoDS:master Dec 1, 2022
@QilongTang QilongTang deleted the DYN-5286-MLNodeAutocomplete-Analytics branch December 1, 2022 01:57
QilongTang added a commit that referenced this pull request Dec 1, 2022
* DYN-5286-MLNodeAutocomplete-Analytics

I added the code for TrackEvent in 4 places:
- NodeAutoCompleteSearchControl.xaml.cs - when clicking the Low Confidence combobox for displaying the list of nodes.
- NodeAutoCompleteSearchViewModel.cs - when the Node Autocomplete is raised using the Recommented nodes option or the Object Types option.
- PreferencesView.xaml.cs when the Slider Confidence Level is updated.
And finally I've added additional Actions in IAnalyticsClient.cs

* DYN-5286-MLNodeAutocomplete-Analytics CodeReview1

Removed the Actions added in IAnalyticsClient.cs so we can re-use the existing ones (so the method calls were also updated).
Added Analytics track events in the Preferences panel when the NodeAutocomplete is se to ML Recomentations or Object Type.
The ExportSettings option and ImportSettings option were renamed to Export and Import (so the method calls were also updated).

* Update

* update

* Update

Co-authored-by: Aaron (Qilong) <[email protected]>
@QilongTang QilongTang mentioned this pull request Dec 1, 2022
8 tasks
QilongTang added a commit that referenced this pull request Dec 1, 2022
* Fix CustomNode view layout after it is saved. (#13585)

* Fix CustomNode views after it is saved.

* Add test

* Update WorkspaceSaving.cs

* Single quote to double quote in js call functions (#13586)

* DYN-5286-MLNodeAutocomplete Adding Analytics  (#13581)

* DYN-5286-MLNodeAutocomplete-Analytics

I added the code for TrackEvent in 4 places:
- NodeAutoCompleteSearchControl.xaml.cs - when clicking the Low Confidence combobox for displaying the list of nodes.
- NodeAutoCompleteSearchViewModel.cs - when the Node Autocomplete is raised using the Recommented nodes option or the Object Types option.
- PreferencesView.xaml.cs when the Slider Confidence Level is updated.
And finally I've added additional Actions in IAnalyticsClient.cs

* DYN-5286-MLNodeAutocomplete-Analytics CodeReview1

Removed the Actions added in IAnalyticsClient.cs so we can re-use the existing ones (so the method calls were also updated).
Added Analytics track events in the Preferences panel when the NodeAutocomplete is se to ML Recomentations or Object Type.
The ExportSettings option and ImportSettings option were renamed to Export and Import (so the method calls were also updated).

* Update

* update

* Update

Co-authored-by: Aaron (Qilong) <[email protected]>

* DYN-5426 Setting different font size when the height of the library is smaller (#13578)

* Setting different font size when the height is smaller

* calculate the font size based on the screen height

Co-authored-by: reddyashish <[email protected]>
Co-authored-by: filipeotero <[email protected]>
Co-authored-by: Roberto T <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants