DYN-8843 Code only Annotation View #16252
Conversation
# Conflicts: # src/DynamoCoreWpf/Views/Core/NodeView.xaml # src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8843
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
zeusongit
requested review from
Copilot,
reddyashish,
saintentropy and
aparajit-pratap
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Eliminates the code and event handlers related to the collapsedGroupThumb in AnnotationView.xaml.cs, simplifying the resize logic and removing unused functionality for collapsed annotations.
There was a problem hiding this comment.
Pull Request Overview
This PR revises the annotation view implementation by transitioning to a code-only approach, which is expected to yield performance improvements in graphs with a high number of groups. Key changes include:
- Updating test cases to retrieve context menu items through the AnnotationGrid rather than direct properties.
- Removing numerous unused XML namespace declarations and XAML resource definitions in the AnnotationView, streamlining the view's implementation.
- Adjusting the event invocation for ungrouping annotations in tests to match the new UI hierarchy.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/DynamoCoreWpfTests/GroupStylesTests.cs | Modified context menu reference for group style menu item. |
| test/DynamoCoreWpfTests/AnnotationViewTests.cs | Changed how the ungroup annotation menu item is retrieved and invoked. |
| src/DynamoCoreWpf/Views/Core/AnnotationView.xaml | Removed unused XML namespace declarations and XAML resources to simplify markup. |
Comments suppressed due to low confidence (2)
test/DynamoCoreWpfTests/GroupStylesTests.cs:111
- The context menu is now accessed via 'AnnotationGrid.ContextMenu'. Ensure that this change is consistently applied across the project if other components rely on the previous 'AnnotationContextMenu' property.
var groupStylesMenuItem = annotationView.AnnotationGrid.ContextMenu
src/DynamoCoreWpf/Views/Core/AnnotationView.xaml:4
- Multiple unused XML namespace declarations and resource definitions have been removed. Confirm that these changes do not affect any code-behind references or dependent components.
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
Purpose
This is built on top of #16188 which needs to me merged first and then rebased.
The PR changes how annotations are implemented using code behind logic, similar to what is proposed for nodes in the other PR.
The changes seems to have performance improvements in cases when graphs have a huge number of groups.
Results:
Manekin: 94s -> 84s (~7%)
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of