Cherr-pick revert of heterogeneous list fix and add workflow test that highlights performance degradation #9441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* revert partial fix to heterogeneous lists * mark failing tests
aparajit-pratap
changed the title
aparajit-pratap
changed the title
|
@aparajit-pratap For the new test added, is there other changes needed for it to be part of the performance suite? |
|
@QilongTang at the moment I don't think we have a "performance test-suite" per se. A good candidate for performance tests I think could be workflow tests and system integration tests. We may need to come up with more specifically tailored to highlight perf aspects once we have some kind of perf test framework in place. |
reddyashish
added a commit
to reddyashish/Dynamo
that referenced
this pull request
May 23, 2019
reddyashish
added a commit
to reddyashish/Dynamo
that referenced
this pull request
May 23, 2019
This was missed while cherrypicking DynamoDS#9441
7 tasks
QilongTang
pushed a commit
that referenced
this pull request
May 28, 2019
* Cherry-picking #9388 into 2.0.3 * Cherry-picking #9559 into 2.0.3 * Cherry-picking #9578 into 2.0.3 * cherry-picking #9632 into 2.0.3 * cherry-picking #9408 into 2.0.3 * cherry-picking #9441 into 2.0.3 * Adding gradient.png for the Test_PerforationsByImage test. This was missed while cherrypicking #9441 * Removing DSCoreDataTests.cs as this was the test fixture was introduced in a different commit and is not needed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is a cherry-pick (from RC 2.1) to revert partial fix to heterogeneous lists, which led to a performance degradation with certain cases of homogeneous nested lists. See #9429. It also contains a workflow test taken from Revit test suite that highlighted the degradation in performance.
Reverting the partial fix causes some edge cases to be unresolved, which are marked as failing test cases in this PR. There is a follow-up bug to resolve these remaining cases (without compromising performance of course) : https://jira.autodesk.com/browse/DYN-1496
Declarations
Check these if you believe they are true
*.resxfilesFYIs
@mjkkirschner @QilongTang