Open
Conversation
waodim
requested review from
Edivion,
StefanHauth,
andriisoldatenko,
avorima,
gkrenn,
jdanieck and
svfoxat
avorima
reviewed
May 4, 2026
avorima
reviewed
May 4, 2026
avorima
reviewed
May 4, 2026
mihaitanasedt
requested changes
May 4, 2026
mihaitanasedt
previously approved these changes
May 5, 2026
avorima
reviewed
May 5, 2026
|
|
||
| // If gen2 with no /api path: append /api for the API client | ||
| if path.Base(base.Path) != "api" { | ||
| return base.JoinPath("api"), &platform |
Contributor
There was a problem hiding this comment.
sorry, i mixed up some requirements. to map an AG 2nd gen to 3rd gen, we just have to strip the /api, but for any other URL we need to add the "apps" part in the domain. I'm thinking that maybe we're being too smart about this.
Contributor
Author
|
The approach on how to do the mapping of URLs is being discussed. Up until a decision is reached do not merge this PR. |
mihaitanasedt
dismissed
their stale review
Dismiss review until a decision is reached
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this we are now storing the tenant phase in the DK status by querying it via client. A new field is added to the DK status and it is populated with the response (essentially just an int).
ICP-3199
How can this be tested?