ctsm5.3.033: MIMICS updates#2365
Conversation
Resolved Conflicts:
python/ctsm/site_and_regional/run_neon.py
by updated to master
|
@slevis-lmwg the parameter files listed above has |
|
I checked out this branch, added the code that we discussed, and pointed to the above params file. The model builds and runs. I tried to push back to the branch, but I do not have permissions. The files to copy to your /SourceMods are: |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
That was a quick Friday afternoon! Thanks. You can teach me how to grant permissions at some point, but I'll kick off a few runs with these code modifications and see how they look next week. |
|
also fixes #2248, by adding the density dependent microbial turnover (beta) @elisacw, and @mvdebolskiy I've merged this PR up to the latest tag (ctsm5.2.028). I'll also point to an updated parameter file that can be found here. |
|
@elisacw, can you make an updated parameterfile with mimicsplus params out of the one Will pointed to? |
|
From conversation @wwieder @slevis-lmwg: Will updates paramfiles. to being read from the paramfile with these names UPDATE see here: /glade/derecho/scratch/wwieder/param_mods |
|
|
derecho aux_clm results Otherwise, also OK: I expected the diffs in mimics cases but not in these ciso cases. However, I see (and remember discussing with @wwieder) that the most recent previous ciso params file had roundoff diffs from the rest for no reason that we could identify. The new one does not have such diffs. |
|
Just remembered, was there another parameter file I needed to create for testing purposes? |
There are two (CN30 and ciso), and I went ahead and made them. |
slevis-lmwg
added
science
slevis-lmwg
left a comment
slevis-lmwg
left a comment
There was a problem hiding this comment.
The changes seem reasonably straightforward and follow the existing code setup that we put in place for mimics a few years ago. I will approve when @wwieder checks the ChangeLog and when this PR gets in line for merging to master.
|
There are also some modifications to the default mimics parameters, but nothing that needs to be documented here beyond noting a change in the log |
Add option for CRUJRA2024, add corresponding compsets for Clm6 and Clm5 Did not change the defaults and, therefore, did not change answers. We will make a separate answer-changing PR to address Clm6 tests that do not specify the datm input, so that they get CRUJRA2024 instead of GSWP3v1. I.e. at that time we will change the defaults. slevis resolved conflicts: doc/ChangeLog doc/ChangeSum
|
github-project-automation
Bot
moved this from In progress - master/b4b-dev
to Done (non release/external)
in CTSM: Upcoming tags
github-project-automation
Bot
moved this from In Progress
to Done
in LMWG: Sprint Planning Board
Add litterfall fluxes that bypass litter pools, directly contributing to SOM Also - remove NPP control on turnover - fix density dependent control on turnover - address varying microbial turnover with depth Introduces new paramfiles. PR ESCOMP#2365 Issues ESCOMP#2361 MIMICS todo list ESCOMP#2248 Should microbial turnover vary with depth in MIMICS?
4 participants
Description of changes
code and parameter changes to address #2361
Specific notes
removes NPP control on turnover
fixes density dependent control on turnover
adds litterfall fluxes that bypass litter pools, directly contributing to SOM
Contributors other than yourself, if any:
@slevis-lmwg
CTSM Issues Fixed (include github issue #):
Fixes #2361
Fixes #2248
Are answers expected to change (and if so in what way)?
Soil C stocks will change with these code and parameter updates
Any User Interface Changes (namelist or namelist defaults changes)?
/glade/u/home/wwieder/scratch/mimics_NEON/modified parameter file available ctsm51_params.c240207b_v1.3_t1.5_b1.5.nc
Testing performed, if any:
scientific testing in single point cases is ongoing