Add GitHub workflows to check black, pylint, git-fleximod#2964
Add GitHub workflows to check black, pylint, git-fleximod#2964samsrabin merged 44 commits intoESCOMP:b4b-devfrom
Conversation
4bbccde to
b5752fa
Compare
ee38886 to
c520d31
Compare
|
@ekluzek Reminding you to review, as discussed. Thanks! |
|
|
|
#2982 is merged, so this is unblocked. |
|
@ekluzek This is complete and ready for review. Thanks! |
|
Blocking #2809. |
Now a failed pylint check should actually be marked as failing.
ekluzek
left a comment
There was a problem hiding this comment.
I have one thing I suggest you do. But, other than that this is great. You found a solution for a problem that I didn't, so the resulting workflow is better than before.
The one suggestion is to possibly keep the two step create and then initialize in py_env_create. So we should talk if you disagree.
So I've marked as approve so you don't have to wait on anything from me. We could even talk about the two step thing later.
|
This also gets me thinking about adding some more tests in a future PR that could be done at some frequency. The python unit tests for example. Maybe we add some longer tests like them to happen less often then with each push, but maybe even something like nightly. |
|
Running tests on a schedule is definitely a good idea in general. I actually have one in the docs revamp PR that checks once per week that |
Description of changes
blackandpylintworkflows only run when relevant files are changedblackandpylintworkflows usectsm_pylibconda environmentSpecific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed:
Because I'm assuming we only want to support people running/linting our tools in
ctsm_pyliband not other Python versions:Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: None needed except what GitHub does.