Update single point docs (and improve subset_data etc. erroring)#3002
Update single point docs (and improve subset_data etc. erroring)#3002samsrabin merged 24 commits intoESCOMP:b4b-devfrom
Conversation
|
A short skim of this and I'm liking what I see. Thanks for starting work on this. The simple note you added about single point is a great starting point to have in place. |
|
@ekluzek Sorry for the many pings on this as it went ready/draft/ready, but it's really ready now. Could you please review today so I can merge it before b4b-dev is locked tomorrow? |
ekluzek
left a comment
There was a problem hiding this comment.
The code is great here. I have a long discussion about what to do with the modify_fsurdat unit tests that had to change. I recommend changing it to delete that code, but I'll leave it up to you.
I have several suggestions on the documentation. The main of which I already brought up and we agreed to leave the PTS_MODE documentation, but don't highlight it.
I'm marking this as approve at this point so you can bring it in without tracking me down again for reapproval.
|
Description of changes
subset_dataand related scripts to give descriptive error messages when the user tries something that isn't supported and/or is buggyCorresponding ctsm-docs PR: ESCOMP/ctsm-docs#8
Remaining work:
subset_dataadd the./xmlchangeDATM years commands toshell_commands(as mentioned in Fix bug or update documentation for "How do I create a single-point run with the NUOPC (default) coupler?" #2890)Specific notes
Contributors other than yourself, if any: Katie Rocci, @adrifoster
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? Yes
Testing performed, if any:
As of 7c1d2dc:As of 685e08e (but nothing changed since then is tested in this suite):
clm_pymodstest suiteAs of 79e202d: