Skip to content

User control over snow thermal conductivity scheme over glaciers#3072

Merged
ekluzek merged 19 commits intoESCOMP:b4b-devfrom
wwieder:JordanGlacier
May 1, 2025
Merged

User control over snow thermal conductivity scheme over glaciers#3072
ekluzek merged 19 commits intoESCOMP:b4b-devfrom
wwieder:JordanGlacier

Conversation

@wwieder
Copy link
Copy Markdown
Contributor

@wwieder wwieder commented Apr 16, 2025 •
edited
Loading

Description of changes

Test runs with F and B cases for CESM3 show excessive melt and low albedo over Greenland. Reverting to the Jordan1991 snow thermal conductivity scheme seems to help address these biases, but also appears to slow snowmelt across the Arctic and prevent vegetation growth. This PR will allow different schemes over glacier and non-glacier land units (Jordan and Sturm, respectively).

Specific notes

Current PR is intended for testing only. If this is something we want to merge it's likely better to allow namelist control over schemes used oven glacier and non-glacier land units?

Contributors other than yourself, if any:
@olyson

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)?

  • Yes, should increase albedo and snowpack over glacier regions

Testing performed, if any:

  • running I case to evaluate changes

Additional tasks:

  • Fix lake bug Bill identified below
  • add namelist option for method used over glacier land units

@wwieder wwieder added the science Enhancement to or bug impacting science label Apr 16, 2025
@wwieder wwieder requested a review from olyson April 16, 2025 18:51
@wwieder wwieder self-assigned this Apr 16, 2025
@wwieder wwieder changed the title hacky way to address #3068 hacky way to address #3071 Apr 16, 2025
@wwieder wwieder mentioned this pull request Apr 16, 2025
Closed
ekluzek
ekluzek approved these changes Apr 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense as a starting hack.

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability investigation Needs to be verified and more investigation into what's going on. PR status: needs testing non-b4b Changes answers (incl. adding tests) labels Apr 16, 2025
billsacks
billsacks approved these changes Apr 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks for taking care of this @wwieder !

(For future reference there is a col%lun_itype variable for convenience that prevents you from needing to get col%landunit and then lun%itype, but what you have is equivalent and totally fine, too.)

@billsacks
Copy link
Copy Markdown
Member

billsacks commented Apr 16, 2025

And yes, I agree with this approach:

it's likely better to allow namelist control over schemes used oven glacier and non-glacier land units?

i.e., having separate namelist variables for those two.

olyson
olyson approved these changes Apr 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@olyson olyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.

@wwieder wwieder mentioned this pull request Apr 16, 2025
Open
@wwieder wwieder changed the title hacky way to address #3071 user control over snow thermal conductivity scheme over glacies Apr 17, 2025
@wwieder wwieder added this to the ctsm5.4.0: CMIP7 Datasets milestone Apr 17, 2025
@github-project-automation github-project-automation Bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Apr 17, 2025
@wwieder wwieder moved this from Ready to start (or start again) to In progress - master in CTSM: Upcoming tags Apr 17, 2025
@ekluzek ekluzek changed the title user control over snow thermal conductivity scheme over glacies User control over snow thermal conductivity scheme over glaciers Apr 17, 2025
@wwieder wwieder mentioned this pull request Apr 29, 2025
Open
ekluzek
ekluzek reviewed Apr 29, 2025
View reviewed changes
Comment thread src/biogeophys/LakeFluxesMod.F90 Outdated
ekluzek added 3 commits April 29, 2025 10:44
@ekluzek
Revert "error logs fail to build, removing"
81b2dfa 
This reverts commit e469029.
@ekluzek
Add in module use statements needed so the error checks will build
f9ac7ac
@ekluzek
Similar changes that I brought in for LakeFluxes and SoilTemperature …
bd5e550 
…around moving use statements for error and logging to the top as well as removing subname as errMsg gives the file and line number and doesn't need to be changed, this makes some progress on ESCOMP#1452
@wwieder wwieder moved this from Todo to In Progress in LMWG: Sprint Planning Board Apr 29, 2025
@ekluzek
Copy link
Copy Markdown
Contributor

ekluzek commented May 1, 2025

This is passing testing other than the st_archive issue, so I'm merging it in now.

@ekluzek ekluzek merged commit e4750c0 into ESCOMP:b4b-dev May 1, 2025
3 checks passed
@github-project-automation github-project-automation Bot moved this from In progress - b4b-dev to Done (non release/external) in CTSM: Upcoming tags May 1, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in LMWG: Sprint Planning Board May 1, 2025
@ekluzek ekluzek deleted the JordanGlacier branch May 1, 2025 18:05
@wwieder wwieder mentioned this pull request May 6, 2025
Open
@slevis-lmwg slevis-lmwg mentioned this pull request May 9, 2025
Merged
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this pull request May 9, 2025
@slevis-lmwg
Merge tag 'ctsm5.3.043' into merge-master-20250509
86c6058 
Merge b4bdev 20250509

Updates to the b4b-dev branch since its last merge to master (PRs ESCOMP#3091 ESCOMP#3092), as shown by git log:

- Merge pull request Update docs infrastructure ESCOMP#2809 from samsrabin/update-docs-builder-2
  Update docs infrastructure
- Merge pull request Update externals to cesm3_0_alpha06c ESCOMP#3106 from ekluzek/update_to_alpha06c
  Update externals to cesm3_0_alpha06c
- Merge pull request User control over snow thermal conductivity scheme over glaciers ESCOMP#3072 from wwieder/JordanGlacier
  User control over snow thermal conductivity scheme over glaciers
ekluzek added a commit to ekluzek/CTSM that referenced this pull request May 9, 2025
@ekluzek
Merge tag 'ctsm5.3.043' into fire_emis
a576300 
Merge b4bdev 20250509

Updates to the b4b-dev branch since its last merge to master (PRs ESCOMP#3091 ESCOMP#3092), as shown by git log:

- Merge pull request Update docs infrastructure ESCOMP#2809 from samsrabin/update-docs-builder-2
  Update docs infrastructure
- Merge pull request Update externals to cesm3_0_alpha06c ESCOMP#3106 from ekluzek/update_to_alpha06c
  Update externals to cesm3_0_alpha06c
- Merge pull request User control over snow thermal conductivity scheme over glaciers ESCOMP#3072 from wwieder/JordanGlacier
  User control over snow thermal conductivity scheme over glaciers

 Conflicts:
	src/biogeochem/CNFireNoFireMod.F90
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this pull request May 10, 2025
@slevis-lmwg
Merge tag 'ctsm5.3.043' into sep_hXi_hXa_tapes_iss1059
fa1ec3b 
Merge b4bdev 20250509

Updates to the b4b-dev branch since its last merge to master (PRs ESCOMP#3091 ESCOMP#3092), as shown by git log:

- Merge pull request Update docs infrastructure ESCOMP#2809 from samsrabin/update-docs-builder-2
  Update docs infrastructure
- Merge pull request Update externals to cesm3_0_alpha06c ESCOMP#3106 from ekluzek/update_to_alpha06c
  Update externals to cesm3_0_alpha06c
- Merge pull request User control over snow thermal conductivity scheme over glaciers ESCOMP#3072 from wwieder/JordanGlacier
  User control over snow thermal conductivity scheme over glaciers
samsrabin added a commit to samsrabin/CTSM that referenced this pull request May 12, 2025
@samsrabin
Merge tag 'ctsm5.3.043' into subset-data-lon-3093
01dfd88 
Merge b4bdev 20250509

Updates to the b4b-dev branch since its last merge to master (PRs ESCOMP#3091 ESCOMP#3092), as shown by git log:

- Merge pull request Update docs infrastructure ESCOMP#2809 from samsrabin/update-docs-builder-2
  Update docs infrastructure
- Merge pull request Update externals to cesm3_0_alpha06c ESCOMP#3106 from ekluzek/update_to_alpha06c
  Update externals to cesm3_0_alpha06c
- Merge pull request User control over snow thermal conductivity scheme over glaciers ESCOMP#3072 from wwieder/JordanGlacier
  User control over snow thermal conductivity scheme over glaciers
glemieux added a commit to glemieux/ctsm that referenced this pull request May 12, 2025
@glemieux
Merge tag 'ctsm5.3.043' into fates-default-param-tag-update
0c452c3 
Merge b4bdev 20250509

Updates to the b4b-dev branch since its last merge to master (PRs ESCOMP#3091 ESCOMP#3092), as shown by git log:

- Merge pull request Update docs infrastructure ESCOMP#2809 from samsrabin/update-docs-builder-2
  Update docs infrastructure
- Merge pull request Update externals to cesm3_0_alpha06c ESCOMP#3106 from ekluzek/update_to_alpha06c
  Update externals to cesm3_0_alpha06c
- Merge pull request User control over snow thermal conductivity scheme over glaciers ESCOMP#3072 from wwieder/JordanGlacier
  User control over snow thermal conductivity scheme over glaciers
samsrabin added a commit to samsrabin/CTSM that referenced this pull request May 14, 2025
@samsrabin
Merge tag 'ctsm5.3.043' into ssp-anomaly-fixes
b8d2a9b 
Merge b4bdev 20250509

Updates to the b4b-dev branch since its last merge to master (PRs ESCOMP#3091 ESCOMP#3092), as shown by git log:

- Merge pull request Update docs infrastructure ESCOMP#2809 from samsrabin/update-docs-builder-2
  Update docs infrastructure
- Merge pull request Update externals to cesm3_0_alpha06c ESCOMP#3106 from ekluzek/update_to_alpha06c
  Update externals to cesm3_0_alpha06c
- Merge pull request User control over snow thermal conductivity scheme over glaciers ESCOMP#3072 from wwieder/JordanGlacier
  User control over snow thermal conductivity scheme over glaciers
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this pull request May 14, 2025
@slevis-lmwg
Merge tag 'ctsm5.3.043' into time_evolv_params
9eab348 
Merge b4bdev 20250509

Updates to the b4b-dev branch since its last merge to master (PRs ESCOMP#3091 ESCOMP#3092), as shown by git log:

- Merge pull request Update docs infrastructure ESCOMP#2809 from samsrabin/update-docs-builder-2
  Update docs infrastructure
- Merge pull request Update externals to cesm3_0_alpha06c ESCOMP#3106 from ekluzek/update_to_alpha06c
  Update externals to cesm3_0_alpha06c
- Merge pull request User control over snow thermal conductivity scheme over glaciers ESCOMP#3072 from wwieder/JordanGlacier
  User control over snow thermal conductivity scheme over glaciers
This was referenced Jan 23, 2026
Closed
Merged
kvrigor added a commit to HPSCTerrSys/eCLM that referenced this pull request Mar 25, 2026
@kvrigor
Snow thermal conductivity changes: Sturm1997 and Jordan1991 (#101)
98054f5 
This PR implements @AdrienDams snow thermal conductivity fixes in CLM5.

> Damseaux, A., Matthes, H., Dutch, V. R., Wake, L., and Rutter, N.: **Impact of snow thermal conductivity schemes on pan-Arctic permafrost dynamics in the Community Land Model version 5.0**, The Cryosphere, 19, 1539–1558, https://doi.org/10.5194/tc-19-1539-2025, 2025.

## New namelist parameters in `lnd_in`

These fixes allow changing the snow thermal conductivity per land unit type. New namelist switches must be added in the `lnd_in` with defaults set to [CLM6 defaults](https://github.com/ESCOMP/CTSM/blob/9f5c3602f9efea2ade07a8f5dcf9eb2b0425d540/bld/namelist_files/namelist_defaults_ctsm.xml#L576-L583).

```fortran
&clm_inparm
 snow_thermal_cond_method = 'Sturm1997'
 snow_thermal_cond_glc_method = 'Sturm1997'
 snow_thermal_cond_lake_method = 'Jordan1991'
```

For reference the namelist parameters reproducing the **old defaults**

```fortran
&clm_inparm
 snow_thermal_cond_method = 'Jordan1991'
 snow_thermal_cond_glc_method = 'Jordan1991'
 snow_thermal_cond_lake_method = 'Jordan1991'
```

## Code changes

Changes were based from these upstream PRs:

- ESCOMP/CTSM#2148
- ESCOMP/CTSM#3072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekluzek ekluzek ekluzek approved these changes

@billsacks billsacks billsacks approved these changes

@olyson olyson olyson approved these changes

Assignees

@wwieder wwieder

@ekluzek ekluzek

Labels

b4b bit-for-bit enhancement new capability or improved behavior of existing capability investigation Needs to be verified and more investigation into what's going on. PR status: needs testing science Enhancement to or bug impacting science

Projects

CTSM: Upcoming tags
Status: Done (non release/external)
LMWG: Sprint Planning Board
Status: Done
CTSM: release-ctsm5.4 minor version update (CMIP7 datasets)
Status: Done

Milestone

cesm3_0_beta07

Development

Successfully merging this pull request may close these issues.

Lake snow thermal conductivity hard coded to Jordan Option to use Jordan1991 over glacier land units

4 participants

@wwieder @billsacks @ekluzek @olyson